Siem query review #40279
Merged
Siem query review #40279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
loe:medium
|
Pinging @elastic/secops |
💔 Build Failed |
cwurm
suggested changes
Jul 4, 2019
There was a problem hiding this comment.
Amazing work @stephmilovic! I'm so happy by the reduction in code size here. Left two comments in here, and then a few more in https://github.com/elastic/ingest-dev/issues/572.
x-pack/legacy/plugins/siem/server/lib/kpi_hosts/query_authentication.dsl.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
cwurm
approved these changes
Jul 8, 2019
💚 Build Succeeded |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Jul 8, 2019
stephmilovic
added a commit
that referenced
this pull request
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented @cwurm 's query optimization review: https://github.com/elastic/ingest-dev/issues/572
Please cross reference the issue while reviewing this PR.
This includes:
mustclauses inboolqueries withfiltertermovermatch_phraseto get exact matchestrack_total_hitscan befalseTo manually test:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately