-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Fixes url state request once initial state #38955
Merged
stephmilovic
merged 2 commits into
elastic:master
from
stephmilovic:fix-url-state-request-once-initial-state
Jun 14, 2019
Merged
[SIEM] Fixes url state request once initial state #38955
stephmilovic
merged 2 commits into
elastic:master
from
stephmilovic:fix-url-state-request-once-initial-state
Jun 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
XavierM
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I played with it a lot and make sure that everything was stored in the URL state was correct.
Good job on refactoring!!!
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Jun 14, 2019
[SIEM] Fix url state request once initial state
stephmilovic
added a commit
that referenced
this pull request
Jun 14, 2019
stephmilovic
added a commit
that referenced
this pull request
Jun 14, 2019
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the
<UrlStateContainer />
to the top level home page. This allows us to set the initial state from the URL before the queries start. This cuts in half our table queries on initial page load.To test:
Play around with the network and host pages and detail pages. Ensure that the URL state gets set if it is not there and when you change pages, and that Redux updates initial url state before querying (is there only one query for each table on page load)
Before:

After:

Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately