Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Fixes url state request once initial state #38955

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jun 13, 2019

Summary

This PR moves the <UrlStateContainer /> to the top level home page. This allows us to set the initial state from the URL before the queries start. This cuts in half our table queries on initial page load.

To test:

Play around with the network and host pages and detail pages. Ensure that the URL state gets set if it is not there and when you change pages, and that Redux updates initial url state before querying (is there only one query for each table on page load)

Before:
Screen Shot 2019-06-13 at 5 48 32 PM

After:
Screen Shot 2019-06-13 at 5 47 29 PM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I played with it a lot and make sure that everything was stored in the URL state was correct.

Good job on refactoring!!!

@stephmilovic stephmilovic merged commit cd76109 into elastic:master Jun 14, 2019
@stephmilovic stephmilovic deleted the fix-url-state-request-once-initial-state branch June 14, 2019 17:42
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jun 14, 2019
[SIEM] Fix url state request once initial state
stephmilovic added a commit that referenced this pull request Jun 14, 2019
[SIEM] Fix url state request once initial state
stephmilovic added a commit that referenced this pull request Jun 14, 2019
[SIEM] Fix url state request once initial state
@FrankHassanabad FrankHassanabad changed the title Fix url state request once initial state [SIEM] Fix url state request once initial state Jul 30, 2019
@FrankHassanabad FrankHassanabad changed the title [SIEM] Fix url state request once initial state [SIEM] Fixes url state request once initial state Jul 30, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants