[SIEM] bugfix data fetch error in Uncommon Processes table #38706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/secops |
stephmilovic
changed the title
XavierM
approved these changes
Jun 11, 2019
angorayc
reviewed
Jun 11, 2019
| @@ -75,7 +75,7 @@ export const getHits = ( | |||
| export const getHosts = (buckets: ReadonlyArray<{ key: string; host: HostHits }>) => | |||
| buckets.map(bucket => ({ | |||
| id: [bucket.key], | |||
| name: bucket.host.hits.hits[0]._source.host.name, | |||
| name: get('host.name', bucket.host.hits.hits[0]._source), | |||
There was a problem hiding this comment.
Nice solution! But I would be more confident if put it like this, not sure if buckets always return with elements or elements in expected format.
get(`host.hits.hits.0._source.host.name`, bucket),
There was a problem hiding this comment.
This just pushes the problem into the get. i can do 2 gets?
There was a problem hiding this comment.
i updated it, lmk what you think
|
@XavierM I looked all over but did not see it anywhere |
💚 Build Succeeded |
💔 Build Failed |
FrankHassanabad
approved these changes
Jun 11, 2019
💚 Build Succeeded |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Jun 12, 2019
…8706) [SIEM] bugfix data fetch error in Uncommon Processes table
stephmilovic
added a commit
that referenced
this pull request
Jun 12, 2019
stephmilovic
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue that caused a data fetch error in the Uncommon Processes table as outlined in this issue: https://github.com/elastic/ingest-dev/issues/526
The issue was caused by some
_sourcedata being in the form of{ 'host.name': 'blah' }and we were reading the data using dot notation, which only works for this form{ host: { name: 'blah' } }. By using lodash'sget, graphql will now be able to read the host data object whether it'shost {orhost.*.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately