Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Additional Overview Network & Hosts metrics #38005

Merged
merged 5 commits into from
Jun 6, 2019

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jun 4, 2019

Summary

Adds new network and host metrics to the SIEM overview page as per https://github.com/elastic/ingest-dev/issues/502

This is a lot of gql boilerplate. The file that matters most for code review is the query dsl: x-pack/plugins/siem/server/lib/overview/query.dsl.ts

[NOTE]: I am still wrestling to get data into my esarchiver tests, please ignore the 0's for now.
[OTHER NOTE]: Palo Alto and Cisco data is not on the siem-dev cluster, so ignore those 0's as well

Screen Shot 2019-06-04 at 10 00 47 AM

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/secops

@angorayc
Copy link
Contributor

angorayc commented Jun 5, 2019

Thanks @stephmilovic , checked out and viewed with chrome, firefox, safari, and IE11, all looks fine. Good to merge once build success.
Screenshot 2019-06-06 at 03 48 02

@stephmilovic
Copy link
Contributor Author

jenkins retest this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stephmilovic stephmilovic merged commit 8b1b295 into elastic:master Jun 6, 2019
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jun 6, 2019
[SIEM] Additional Overview Network & Hosts metrics (elastic#38005)
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jun 6, 2019
[SIEM] Additional Overview Network & Hosts metrics (elastic#38005)
stephmilovic added a commit that referenced this pull request Jun 6, 2019
[SIEM] Additional Overview Network & Hosts metrics (#38005)
stephmilovic added a commit that referenced this pull request Jun 6, 2019
[SIEM] Additional Overview Network & Hosts metrics (#38005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants