[SIEM] Better URL state tests #37745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/secops |
💚 Build Succeeded |
XavierM
approved these changes
Jun 3, 2019
x-pack/plugins/siem/public/components/url_state/index_mocked.test.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
FrankHassanabad
pushed a commit
to FrankHassanabad/kibana
that referenced
this pull request
Jun 7, 2019
Better SIEM URL state tests
FrankHassanabad
added a commit
that referenced
this pull request
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
.skip()from and refactors the URL State tests to not usewait(). This was so frustrating! None of the methods to mock a singlelodashmethod (throttle) were working for me. The only way I could do it was by mocking all oflodash/fpand then forcing a.mockImplementation()ontothrottle. This broke a bunch of other tests, so I split out thethrottlemocked tests into their own file and moved dependencies totest_dependencies.tsChecklist
- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately