Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate #37385

Merged
merged 16 commits into from
May 29, 2019
Merged

Configure Renovate #37385

merged 16 commits into from
May 29, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 29, 2019

Welcome to Renovate! This is an onboarding PR to help you understand and configure settings before regular Pull Requests begin.

🚦 To activate Renovate, merge this Pull Request. To disable Renovate, simply close this Pull Request unmerged.


Configuration

🔡 Renovate has detected a custom config for this PR. Feel free to ask for help if you have any doubts and would like it reviewed.

Important: Now that this branch is edited, Renovate can't rebase it from the base branch any more. If you make changes to the base branch that could impact this onboarding PR, please merge them manually.

What to Expect

With your current configuration, Renovate will create 2 Pull Requests:

Pin dependencies
Update babel related packages

❓ Got questions? Check out Renovate's Docs, particularly the Getting Started section.
If you need any further assistance then you can also request help here.


This PR has been generated by Renovate Bot. View repository job log here.

@elasticmachine

This comment has been minimized.

@spalger spalger added Team:Operations Team label for Operations Team review v8.0.0 labels May 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger spalger requested a review from mistic May 29, 2019 20:38
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and questions but otherwise LGTM

* This deletes and re-creates the lock file, which we will only want
* to turn on once we've updated all our deps
*/
lockFileMaintenance: { enabled: false },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will never want this enabled right? Or do you think renovate will support well our yarn lock file generation logic with the workspaces + every package.json across the repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will work once we've got the packages up to date.

@spalger spalger merged commit 07ef100 into master May 29, 2019
@renovate renovate bot deleted the renovate/configure branch May 29, 2019 21:15
jkakavas pushed a commit to jkakavas/kibana that referenced this pull request May 30, 2019
* Add renovate.json

* Update and rename renovate.json to renovate.json5

* Update renovate.json5

* Update renovate.json5

* extend the base config

* remove enabled:false

* skip the part limiting managers, we point to specific package.json files instead

* try to disable updating all but eslint packages

* nest npm specific config

* fix syntax error

* bad copy job

* tweak labels

* disable update requests for `@kbn/` packages

* stop overriding rangeStategy

* extend package.json selectors

* add a couple more package.json files
@timroes timroes added the release_note:skip Skip the PR/issue when compiling release notes label Apr 26, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 28, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 37385 or prevent reminders by adding the backport:skip label.

@spalger spalger added the backport:skip This commit does not require backporting label Apr 28, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Team label for Operations Team v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants