-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url state #36663
Url state #36663
Conversation
💔 Build Failed |
💚 Build Succeeded |
Pinging @elastic/secops |
💔 Build Failed |
💚 Build Succeeded |
Thanks for taking care of this @stephmilovic! I followed the past above but found that the status for date-picker persisted well, but my kql query is unable to remain after refreshing page. Please let me know if you can reproduce it. |
@angorayc thanks for reviewing. Can you please post the full url? it might be because the kql query does not persist between pages, only on the page it was set |
This is what I've got, seems that kql is not a part of it. Hope it helps
|
I think we should have an empty state URL on initialization. So an user can still share their URL and show what they saw at this time |
@angorayc I think that you found a usability bug, we should link the refresh button to apply the KQL search in the KQL bar. |
if (globalRange.linkTo.length === 0) { | ||
this.props.toggleTimelineLinkTo({ linkToId: 'global' }); | ||
} | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toggleTimelineLinkTo: inputsActions.toggleTimelineLinkTo, | ||
} | ||
// @ts-ignore | ||
)(UrlStateComponents); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and please create issues so we can track these problems
Opened this issue for the remaining work: https://github.com/elastic/ingest-dev/issues/447 |
- track SIEM app state in url
Uses url parameters to store timerange and kql data. Also tracks whether the timerange is locked or not
I have a couple more tests to write but wanted to get the PR up.
Happy path manual tests: