[Code] fix query string key conflict #36620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
spacedragon
reviewed
May 22, 2019
| @@ -57,7 +57,7 @@ export class EditorComponent extends React.Component<IProps> { | |||
|
|
|||
| public componentDidMount(): void { | |||
| this.container = document.getElementById('mainEditor') as HTMLElement; | |||
| this.monaco = new MonacoHelper(this.container, this.props); | |||
| this.monaco = new MonacoHelper(this.container, this.props, this.props.location.search); | |||
There was a problem hiding this comment.
What if the location.search changed after the editor is created?
spacedragon
reviewed
May 22, 2019
| @@ -18,7 +19,7 @@ export function registerReferencesAction(e: editor.IStandaloneCodeEditor) { | |||
| const position = ed.getPosition(); | |||
| const { uri } = parseSchema(ed.getModel().uri.toString()); | |||
| const refUrl = `git:/${uri}!L${position.lineNumber - 1}:${position.column - 1}`; | |||
| const queries = queryString.parse(location.search); | |||
| const queries = url.parse(search, true).query; | |||
There was a problem hiding this comment.
Is there a way to get the search from current url instead of passing by a parameter?
There was a problem hiding this comment.
window.location.search is empty if query string is after the hash.
💚 Build Succeeded |
spacedragon
approved these changes
May 24, 2019
WangQianliang
pushed a commit
that referenced
this pull request
May 24, 2019
WangQianliang
pushed a commit
that referenced
this pull request
May 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix query string key conflict
history.searchwould be empty if placed after a hash