Page Headline and Last Beat Stat Query #35376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/secops |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Looks there's an issue when navigating between certain routes as the last beat doesn't re-query and stays as the previous value from the cache.
|
spong
reviewed
Apr 23, 2019
💔 Build Failed |
spong
reviewed
Apr 23, 2019
x-pack/plugins/siem/server/lib/events/query.last_event_time.dsl.ts
Outdated
Show resolved
Hide resolved
spong
reviewed
Apr 23, 2019
x-pack/plugins/siem/server/lib/events/query.last_event_time.dsl.ts
Outdated
Show resolved
Hide resolved
spong
reviewed
Apr 23, 2019
spong
requested changes
Apr 23, 2019
There was a problem hiding this comment.
Checked out/tested locally and also performed a code review. Once Jenkins is happy and the cache/re-query issue is resolved I think this should be g2g! Leaving as request changes for those two items.
I also added an optional or two, but overall, great UI/UX additions and thorough tests. Thanks @stephmilovic! :) 🚀
💔 Build Failed |
|
Jenkins retest this please |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Jenkins retest this |
💔 Build Failed |
💚 Build Succeeded |
spong
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review!
This PR has a lot of code from @MichaelMarcialis to implement some UI design for page headlines and panels. I then took the branch and connected the "Last beat: 5 seconds ago" subheadline for each section (Network, Ip Details, Hosts, Host Details).
Key files:
*Ignore that the gif says in 6 hours, we have some bad data