Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [skip ci] Notification plugin migration #34263

Conversation

peterschretlen
Copy link
Contributor

Summary

Migrating the notifications plugin to the new platform.
At the moment this still runs as a legacy plugin, but shims have been put in place to make it ready for migration to new platform services.

@peterschretlen peterschretlen requested a review from epixa April 1, 2019 13:10
@epixa epixa added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc non-issue Indicates to automation that a pull request should not appear in the release notes Feature:New Platform labels Apr 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@rudolf
Copy link
Contributor

rudolf commented Apr 2, 2019

There's a few places where the old JS code had JSDoc comments with type information like @param {NotificationService} notificationService The notification service singleton. Since typescript now takes care of the types we can remove the {NotificationService} type specifier from these JSDoc comments.

The (relatively new) TSDoc standard requires that there's a - between paramater names and their description so the above comment would become:
@param notificationService - The notification service singleton.

We don't parse the TSDoc comments in plugins, so it's not a strong requirement to stick to the spec.

@epixa
Copy link
Contributor

epixa commented Jul 22, 2019

I'm going to close this as I believe we're ready to remove the notifications plugin entirely in favor of the new actions plugin. Thanks for doing this exercise nonetheless!

@epixa epixa closed this Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform non-issue Indicates to automation that a pull request should not appear in the release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants