deduplicate yarn.lock #32760
Closed
deduplicate yarn.lock #32760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-operations |
💔 Build Failed |
|
@jbudz can you add a description and the versions targeting? Did you use a script to de-dupe? |
💔 Build Failed |
💔 Build Failed |
w33ble
approved these changes
Mar 19, 2019
💔 Build Failed |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
jbudz
added
the
non-issue
|
Want to try to go at this again? |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Closing this out for now, there's some parallel efforts that spalger is undertaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes duplicate entries in our lock file using https://github.com/atlassian/yarn-deduplicate. Over time new packages aren't squashed as much as they could by
yarn add. Regenerating yarn.lock does fix this, but it's a significantly larger change as all dependencies are updated according to their semver rules with what's released. It leaves a lot to sort comparative to squashing statically with this approach, based on what's in the file.We ran into one issue with canvas based on an upgraded react types packages and a still open issue. I'll leave it up to the canvas team what we do here, I can rollback that one package or remove the type check, or some alternative.