[Maps] Lock tooltip in place with click #32733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
added
the
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
6 tasks
nreese
reviewed
Mar 8, 2019
nreese
reviewed
Mar 8, 2019
nreese
reviewed
Mar 8, 2019
| import mapboxgl from 'mapbox-gl'; | ||
| import { FeatureTooltip } from '../feature_tooltip'; | ||
|
|
||
|
|
||
| const TOOLTIP_TYPE = { |
There was a problem hiding this comment.
These are constants used by the store and actions. I think they should be defined in a more global location under public/store
There was a problem hiding this comment.
theoretically yes, in practice no. the tooltip-state is only evaluated here to handle moves/clicks correctly. I would move these constants once they are actually being evaluated in the redux flow (e.g, tooltip type will be relevant when trying to preserve tooltips across data-refreshes, but it's not something addressed here).
nreese
reviewed
Mar 8, 2019
💚 Build Succeeded |
💚 Build Succeeded |
thomasneirynck
commented
Mar 12, 2019
| <EuiFlexGroup direction="column" gutterSize="none"> | ||
| <EuiFlexItem grow={true}> | ||
| <EuiFlexGroup alignItems="flexEnd" direction="row" justifyContent="spaceBetween"> | ||
| <EuiFlexItem> </EuiFlexItem> |
There was a problem hiding this comment.
no flexing happens when only single element
💚 Build Succeeded |
nreese
approved these changes
Mar 12, 2019
This was referenced Mar 12, 2019
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Mar 12, 2019
thomasneirynck
added a commit
that referenced
this pull request
Mar 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on a feature now locks the tooltip in place.
This is a small improvement, only adding the click behavior. It does not modify the contents or format of the actual tooltip.