Fix: correctly access types from "to" function

[w33ble]

Closes #32597
Blocked by #32600 (mostly for verification reasons) merged

Types were being pulled from the handlers object, but they are not exposed this way anymore. They must be imported from @kbn/interpreter now.

This PR also makes the to function a browser-only function. Common functions were being registered in both places, but thanks to #33039, it was only ever run on the server, which there is no longer any need for.

This PR makes the following expression demodata | to type="null" go from this:

To this:

---

To test, you'll need to need to merge/rebase with #32600, otherwise you're going to see other error messages (specifically, "See server logs for details" and "Function to did not return anything.").

[elasticmachine]

Pinging @elastic/kibana-canvas

[w33ble]

@chrisdavies it occurred to me that we may need to check the environment to get the right registry, since we (I think incorrectly) have two different ones. I think without this, we'd end up bundling the wrong registry in the browser...

diff --git a/x-pack/plugins/canvas/common/functions/to.js b/x-pack/plugins/canvas/common/functions/to.js
index 9344265f59..cf47606a6a 100644
--- a/x-pack/plugins/canvas/common/functions/to.js
+++ b/x-pack/plugins/canvas/common/functions/to.js
@@ -5,7 +5,8 @@
  */
 
 import { castProvider } from '@kbn/interpreter/common';
-import { registries } from '@kbn/interpreter/server';
+import { registries as serverRegistries } from '@kbn/interpreter/server';
+import { registries as browserRegistries } from '@kbn/interpreter/public';
 
 export const to = () => ({
   name: 'to',
@@ -20,11 +21,13 @@ export const to = () => ({
       multi: true,
     },
   },
-  fn: (context, args) => {
+  fn: (context, args, { environment }) => {
     if (!args.type) {
       throw new Error('Must specify a casting type');
     }
 
+    const registries = environment === 'client' ? browserRegistries : serverRegistries;
+
     return castProvider(registries.types.toJS())(context, args.type);
   },
 });

Thoughts?

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[clintandrewhall]

LGTM

[w33ble]

OK, no need to handle the browser registries stuff, the server function is always used thanks to #33039.

[w33ble]

I've updated the PR to make the to function only run in the browser, seemed like that made the most sense and was the least likely to break in the future (ie. once #33039 is fixed).

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request