You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a addError method to the toastNotification service, to show a toast for an error, which allows expanding that error in a modal to see the full stacktrace. This PR also uses that new service in Discover, so you can test it (e.g. by creating an invalid filter in Discover).
Also it will add back using the appropriate configuration settings from the ui settings to configure the actual toast timeouts (this was lost at some point when moving over to the toast notifications I assume).
@timroes After merging master on this, it doesn't look like the exception handlers in the Discover contoroller are getting called when there is a syntax error. I don't know enough about how this code works to know where to begin to look.
@joshdover Could you describe what you did in discover to trigger them. Entering e.g. :foo:bar into the query bar as Caroline did in her screencast should have revealed them?
@joshdover Could you describe what you did in discover to trigger them. Entering e.g. :foo:bar into the query bar as Caroline did in her screencast should have revealed them?
I was able to get that working, guess the string I was using wasn't triggering an error anymore. 🤷♂
release_note:skipSkip the PR/issue when compiling release notesTeam:CoreCore services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etcv7.3.0v8.0.0
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
addErrormethod to thetoastNotificationservice, to show a toast for an error, which allows expanding that error in a modal to see the full stacktrace. This PR also uses that new service in Discover, so you can test it (e.g. by creating an invalid filter in Discover).Also it will add back using the appropriate configuration settings from the ui settings to configure the actual toast timeouts (this was lost at some point when moving over to the toast notifications I assume).
cc @cchaos
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers