-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Skip tests for cloud #30879
[Monitoring] Skip tests for cloud #30879
Conversation
Pinging @elastic/stack-monitoring |
@chrisronline I'm okay with the skips here as long as we have an issue to re-enable these tests with the proper resolution. Could you create such an issue (if necessary) and link to it from a TODO comment above each |
💚 Build Succeeded |
@chrisronline In your TODO comments you linked to https://github.com/elastic/stack-monitoring/issues/31. But according to this PR's description, merging this PR will resolve https://github.com/elastic/stack-monitoring/issues/31. This causes two problems, IMO:
I'd prefer creating a new issue (separate from https://github.com/elastic/stack-monitoring/issues/31) that's clearly about re-enabling the tests with proper resolution and linking to that issue from the TODO comments. But if you think this is unnecessary and we won't lose track of these skipped tests, then this PR LGTM. |
I'd prefer to keep a single ticket. I'm going to update the ticket to include this better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
💔 Build Failed |
retest |
💚 Build Succeeded |
* Skip tests for cloud * Add TODOs
* Skip tests for cloud * Add TODOs
* Skip tests for cloud * Add TODOs
Relates to https://github.com/elastic/stack-monitoring/issues/31
Resolves #30707
Resolves #30708
Resolves #30709
Resolves #30713
This PR adds logic to skip certain monitoring tests for cloud. The reasons are explained in each ticket. In the future, we can resolve these properly, but skipping for now will help avoid these unnecessary failures. None of the failures are due to an actual bug in the code.