Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Restore mappings.json #30153

Merged
merged 4 commits into from
Feb 6, 2019
Merged

[Monitoring] Restore mappings.json #30153

merged 4 commits into from
Feb 6, 2019

Conversation

chrisronline
Copy link
Contributor

Fixes #30152

See the ticket for more information. This only affects tests.

@chrisronline chrisronline self-assigned this Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

chrisdavies
chrisdavies approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't test-- Jenkins did. But maybe we should open an issue or something to update es_archiver so that it produces mappings like these for indices that are owned by Elasticsearch. I think right now, es_archiver will dump the full mapping into these files if you ever ask it to update things.

@chrisronline chrisronline merged commit 7c376e9 into elastic:master Feb 6, 2019
@chrisronline chrisronline mentioned this pull request Feb 6, 2019
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Feb 6, 2019
@chrisronline
Backport elastic#30153
c2a7c9e
@chrisronline chrisronline deleted the monitoring/mappings_json branch February 6, 2019 15:02
chrisronline added a commit that referenced this pull request Feb 7, 2019
@chrisronline
[6.7] [Monitoring] Restore mappings.json (#30153) (#30244)
55aae40 
* Backport #30153

* Upgrade elasticsearchjs to 15.4

* Bump consistently

* Default to 6.7

* Revert "Default to 6.7"

This reverts commit 4f9de6e.

* Revert "Bump consistently"

This reverts commit 9588431.

* Revert "Upgrade elasticsearchjs to 15.4"

This reverts commit 8ea162d.
@chrisronline
Copy link
Contributor Author

Backport:

6.7: 55aae40

@chrisronline chrisronline mentioned this pull request Feb 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavies chrisdavies chrisdavies approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator

Assignees

@chrisronline chrisronline

Labels
review Team:Monitoring Stack Monitoring team v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisronline @elasticmachine @chrisdavies