-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timelion/hide timelion #30131
Timelion/hide timelion #30131
Conversation
Timelion sheets will continue to work in visualize, but the application will no longer appear in the app switcher by default. The timelion.ui.enabled configuration in kibana.yml will toggle the app on.
…epixa-hide-timelion
Pinging @elastic/kibana-app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - no concerns on my end, assuming the build comes back green.
Tested locally (Chrome OSX), and verified the app switcher icon is hidden by default, but everything else (including hitting the app landing page directly at /app/timelion) continues to function as normal. Icon displays as it used to when the setting is enabled in kibana.yml.
💚 Build Succeeded |
@chrisdavies thanks for jumping on this :) |
Hm. @cchaos I only hopped on this because Court didn't have time to wrap it up. I honestly don't know anything about timelion. @AlonaNadler thoughts about @cchaos's question? |
Would be nice to have if when Timelion is disabled the other Timelion related settings (tutorial, rows, and columns) are disabled as well, not the highest priority but will be nice to have |
@AlonaNadler Could you please create a separate issue for this, since I am not sure if that would still go into 7.0, since it's a new feature (and concept, we don't disable settings like that yet anywhere). |
@timroes I already opened an issue for that #30141 |
@chrisdavies Could you please add this change to the 7.0 Breaking Changes doc? |
@gchaps I'm not familiar with that doc. Where is it? |
@chrisdavies You'll find the doc at kibana/docs/migration/migrate_7_0.asciidoc |
Timelion sheets will continue to work in visualize, but the application
will no longer appear in the app switcher by default. The
timelion.ui.enabled configuration in kibana.yml will toggle the app on.