Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Apply new design to search page #29326

Merged
merged 1 commit into from
Jan 28, 2019
Merged

[Code] Apply new design to search page #29326

merged 1 commit into from
Jan 28, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Jan 25, 2019 •
edited
Loading

@mw-ding mw-ding added the :Code label Jan 25, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding mw-ding changed the title (WIP) [Code] Apply new design to search page [Code] Apply new design to search page Jan 25, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding mw-ding requested a review from spacedragon January 28, 2019 02:08
spacedragon
spacedragon approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@spacedragon spacedragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mw-ding mw-ding merged commit 97752ca into elastic:feature/merge-code Jan 28, 2019
@mw-ding mw-ding deleted the repo-search-page branch January 28, 2019 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedragon spacedragon spacedragon approved these changes

@zfy0701 zfy0701 Awaiting requested review from zfy0701

@WangQianliang WangQianliang Awaiting requested review from WangQianliang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mw-ding @elasticmachine @spacedragon