Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] New design for search scope #29238

Merged
merged 1 commit into from
Jan 24, 2019
Merged

[Code] New design for search scope #29238

merged 1 commit into from
Jan 24, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Jan 24, 2019 •
edited
Loading

Summary

Implement the new design for search scope: https://github.com/elastic/code/issues/802

The shortcut has been applied.

image

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding mw-ding changed the title (WIP) [Code] New design for search scope [Code] New design for search scope Jan 24, 2019
@mw-ding mw-ding added the :Code label Jan 24, 2019
@mw-ding mw-ding requested review from spacedragon and WangQianliang and removed request for spacedragon January 24, 2019 04:23
@elasticmachine
Copy link
Contributor

💔 Build Failed

spacedragon
spacedragon approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@spacedragon spacedragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mw-ding
Copy link
Contributor Author

mw-ding commented Jan 24, 2019

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding
Copy link
Contributor Author

mw-ding commented Jan 24, 2019

jenkins, test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mw-ding mw-ding merged commit 5b1ab0f into elastic:feature/merge-code Jan 24, 2019
@mw-ding mw-ding deleted the mw-search-page branch January 24, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedragon spacedragon spacedragon approved these changes

@WangQianliang WangQianliang Awaiting requested review from WangQianliang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mw-ding @elasticmachine @spacedragon