Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Remove absolute local path from esqueue payload #28741

Merged
merged 1 commit into from
Jan 16, 2019
Merged

[Code] Remove absolute local path from esqueue payload #28741

merged 1 commit into from
Jan 16, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented Jan 15, 2019

Summary

https://github.com/elastic/code/issues/740
Remove absolute local path from esqueue payload so that the path won't be exposed in ES.

@mw-ding mw-ding requested a review from spacedragon January 15, 2019 08:10
@elasticmachine
Copy link
Contributor

💔 Build Failed

@mw-ding mw-ding added the :Code label Jan 16, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

spacedragon
spacedragon approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@spacedragon spacedragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mw-ding mw-ding merged commit 22e5878 into elastic:feature/merge-code Jan 16, 2019
@mw-ding mw-ding deleted the mw-fix-branch branch January 16, 2019 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacedragon spacedragon spacedragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mw-ding @elasticmachine @spacedragon