[Uptime] Fix "last updated" field #28720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime |
justinkambic
changed the title
31 tasks
💚 Build Succeeded |
💚 Build Succeeded |
andrewvc
requested changes
Jan 23, 2019
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 24, 2019
* Update MonitorStatusBar to not reference undefined value. * Add sort to top_hits aggregation. * Add default and loading state for status bar. * Change bool check. * Add aria-labels for monitor status bar.
justinkambic
added a commit
that referenced
this pull request
Jan 25, 2019
* [Uptime] Fix "last updated" field (#28720) * Update MonitorStatusBar to not reference undefined value. * Add sort to top_hits aggregation. * Add default and loading state for status bar. * Change bool check. * Add aria-labels for monitor status bar. * Update expected test result Fix test because of significant digit limitations. * Remove unused code. * Fix bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #28090 we specified that the
Last updatefield on the Monitors Page does not display values consistent with the time since the last update when a monitor is stopped. This happened for a number of reasons.Firstly - when Apollo Query objects receive the same data, by default it gets cached. Also, we weren't sorting the top hits value to ensure the latest doc would always be returned. To top it off - the component was referencing a key on the query result that is always
undefined! To help prevent this from happening in the future I added a reference to the GQL type expected by the query object.In addition to fixing these problems, I also extracted a large portion of this query component into a functional component. I provided a default/loading state for it as well.
Before:
The above image was captured 13 minutes after the last check was received.
After:
Testing this PR
To test this PR: