Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change token auth provider usage of created to invaliated_tokens #27614

Merged
merged 3 commits into from
Jan 10, 2019
Merged

Change token auth provider usage of created to invaliated_tokens #27614

merged 3 commits into from
Jan 10, 2019

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Dec 20, 2018

@kobelb kobelb requested a review from a team as a code owner December 20, 2018 18:42
@kobelb
Copy link
Contributor Author

kobelb commented Dec 20, 2018

/cc @epixa

@kobelb kobelb added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Dec 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@kobelb kobelb added v7.0.0 non-issue Indicates to automation that a pull request should not appear in the release notes labels Dec 20, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@jkakavas
Copy link
Member

If I understood correctly this should not have caused any CI troubles for you but FYI elastic/elasticsearch#36893 is merged

@kobelb
Copy link
Contributor Author

kobelb commented Jan 2, 2019

retest

@kobelb
Copy link
Contributor Author

kobelb commented Jan 2, 2019

Thanks @jkakavas

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb
Copy link
Contributor Author

kobelb commented Jan 2, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb
Copy link
Contributor Author

kobelb commented Jan 2, 2019

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb
Copy link
Contributor Author

kobelb commented Jan 2, 2019

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb requested a review from legrego January 7, 2019 20:23
legrego
legrego approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally

@kobelb kobelb merged commit ff5b0e8 into elastic:master Jan 10, 2019
@kobelb kobelb deleted the token-auth-provider-invalidate branch January 10, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kobelb @elasticmachine @jkakavas @legrego