Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Canvas Icon in Sidebar #27422

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Updates Canvas Icon in Sidebar #27422

merged 1 commit into from
Dec 19, 2018

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Dec 18, 2018

This swaps out the old icon for the new Canvas icon in the navbar.
screen shot 2018-12-17 at 5 06 50 pm

@cqliu1 cqliu1 added review v7.0.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.6.0 v6.5.5 labels Dec 18, 2018
@cqliu1 cqliu1 requested a review from ryankeairns December 18, 2018 19:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@cqliu1 cqliu1 requested a review from a team as a code owner December 18, 2018 19:07
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

w33ble
w33ble approved these changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@w33ble w33ble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize we were getting a new icon. Neat! Looks fine when I open Canvas, and I assume you don't need anyone to check anything else...

@cqliu1 cqliu1 merged commit a40b870 into elastic:master Dec 19, 2018
@cqliu1 cqliu1 deleted the fix/canvas-nav-icon branch December 19, 2018 16:51
@cqliu1 cqliu1 mentioned this pull request Dec 19, 2018
Closed
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
@cqliu1
Switches to new Canvas logo in sidebar nav (elastic#27422)
14476e4
@cqliu1 cqliu1 mentioned this pull request Dec 19, 2018
Closed
cqliu1 added a commit to cqliu1/kibana that referenced this pull request Dec 19, 2018
@cqliu1
Switches to new Canvas logo in sidebar nav (elastic#27422)
1fb63ac
@cqliu1 cqliu1 restored the fix/canvas-nav-icon branch December 19, 2018 17:16
@cqliu1 cqliu1 deleted the fix/canvas-nav-icon branch December 19, 2018 17:16
cqliu1 added a commit that referenced this pull request Dec 19, 2018
@cqliu1
Revert "Switches to new Canvas logo in sidebar nav (#27422)"
cdee6ad 
This reverts commit a40b870.
@cqliu1 cqliu1 mentioned this pull request Dec 19, 2018
Merged
cqliu1 added a commit that referenced this pull request Dec 19, 2018
@cqliu1
Revert "Updates Canvas Icon in Sidebar" (#27516)
0acb406 
* Revert "Adds release notes for 7.0.0-alpha2 (#27237)"

This reverts commit aad71f0.

* Revert "Switches to new Canvas logo in sidebar nav (#27422)"

This reverts commit a40b870.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w33ble w33ble w33ble approved these changes

@ryankeairns ryankeairns Awaiting requested review from ryankeairns

Assignees
No one assigned
Labels
review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v6.5.5 v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cqliu1 @elasticmachine @w33ble