Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI]Adding linking support for APM #27319

Merged
merged 4 commits into from
Dec 17, 2018
Merged

[Infra UI]Adding linking support for APM #27319

merged 4 commits into from
Dec 17, 2018

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Dec 17, 2018 •
edited by alvarolobato
Loading

This PR fixes #26620 by adding a link for each node type to APM. Keep in mind that until #26359 is merged it will still use the old fields. But once it's merged all the fields will match the original issue.

image

@simianhacker simianhacker requested a review from XavierM December 17, 2018 17:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/infrastructure-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

XavierM
XavierM approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

XavierM
XavierM approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still make sense

@simianhacker simianhacker merged commit 4eb5e64 into elastic:master Dec 17, 2018
simianhacker added a commit to simianhacker/kibana that referenced this pull request Dec 17, 2018
@simianhacker
[Infra UI]Adding linking support for APM (elastic#27319)
7e3af6e 
* Fixes elastic#26620 - Adding linking support for APM

* Fixing some weird merge artifacts

* Finalizing URL linking to APM
@simianhacker simianhacker mentioned this pull request Dec 17, 2018
Merged
simianhacker added a commit that referenced this pull request Dec 17, 2018
@simianhacker
[Infra UI]Adding linking support for APM (#27319) (#27351)
46538d2 
* Fixes #26620 - Adding linking support for APM

* Fixing some weird merge artifacts

* Finalizing URL linking to APM
@elasticmachine
Copy link
Contributor

💔 Build Failed

This was referenced Apr 18, 2019
Closed
Closed
@simianhacker simianhacker deleted the fixes-26620 branch April 17, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature review v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Infra UI] Cross-linking between solutions
3 participants
@simianhacker @elasticmachine @XavierM