Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiment with skipping the archive steps #26125

Closed
wants to merge 11 commits into from
Closed

experiment with skipping the archive steps #26125

wants to merge 11 commits into from

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Nov 23, 2018

Based on #26109

@spalger spalger added the WIP Work in progress label Nov 23, 2018
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@spalger spalger force-pushed the implement/build-to-directory branch from 662983d to 682d753 Compare November 26, 2018 16:02
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elastic elastic deleted a comment from elasticmachine Dec 6, 2018
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Merge branch 'master' of github.com:elastic/kibana into implement/bui…
4c7c508 
…ld-to-directory

# Conflicts:
#	src/dev/build/cli.js
@spalger spalger requested a review from a team as a code owner June 12, 2019 20:57
@elasticmachine
Copy link
Contributor

💔 Build Failed

jbudz
jbudz approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest snapshot -u failure. Not against trying it, it's one step further from an irl build but we have other tests for it.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger added the release_note:skip Skip the PR/issue when compiling release notes label Jul 16, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Jul 16, 2019

This doesn't really speed things up enough to be worth the risk I don't think

@spalger spalger closed this Jul 16, 2019
@spalger spalger deleted the implement/build-to-directory branch July 16, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spalger @elasticmachine @jbudz