Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/translate monitoring elasticsearch part 2 #24734

Merged
merged 32 commits into from
Nov 16, 2018
Merged

Feature/translate monitoring elasticsearch part 2 #24734

merged 32 commits into from
Nov 16, 2018

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Oct 29, 2018 •
edited
Loading

Translate monitoring -> public -> directives and views -> kibana and elasticsearch

Fixes: #24713

Nox911 added 17 commits September 24, 2018 18:58
@Nox911
Merge pull request #1 from elastic/master
c7ec189 
update
@Nox911
Merge pull request #2 from elastic/master
fa01b88 
second merge
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
70f6c7e
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
68587a0
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
42aa7d3
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
efeaefe
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
8a054ed
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b0d1660
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
62b6ad1
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
acbad4b
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
a850650
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
0a200ce
@Nox911
Merge branch 'master' of https://github.com/elastic/kibana
b2a8244
@Nox911
Translate monitoring -> view -> elasticsearch
8765f49
@Nox911
Merge branch 'master' into feature/translate-monitoring-elasticsearch…
943550e 
…-part_2
@Nox911
Fix issues
74c236e
@Nox911
Translate monitoring - view - elasticsearch and kibana
c617035
@Nox911 Nox911 requested a review from maryia-lapata October 29, 2018 13:29
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

maryia-lapata
maryia-lapata suggested changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Please fix some comments.

@maryia-lapata
Copy link
Contributor

Title, status and placeholder should be translated as well here:
https://github.com/elastic/kibana/pull/24734/files#diff-42466c1bcff26f4e4275cbe87b295837R89

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911 Nox911 requested a review from chrisronline November 1, 2018 08:19
maryia-lapata
maryia-lapata approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@maryia-lapata maryia-lapata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Nox911
Copy link
Contributor Author

Nox911 commented Nov 2, 2018

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

chrisronline
chrisronline approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata mentioned this pull request Nov 13, 2018
Merged
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@maryia-lapata maryia-lapata merged commit 359c852 into elastic:master Nov 16, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Nov 21, 2018
@Nox911 @maryia-lapata
Feature/translate monitoring elasticsearch part 2 (elastic#24734)
b91361e 
* Translate monitoring -> view -> elasticsearch

* Fix issues

* Translate monitoring - view -  elasticsearch and kibana

* Fix issues

* Fix issues

* Fix issues

* Fix placeholder value
@maryia-lapata maryia-lapata mentioned this pull request Nov 21, 2018
Merged
maryia-lapata added a commit that referenced this pull request Nov 21, 2018
@maryia-lapata
Feature/translate monitoring elasticsearch part 2 (#24734) (#25986)
a4565de 
* Translate monitoring -> view -> elasticsearch

* Fix issues

* Translate monitoring - view -  elasticsearch and kibana

* Fix issues

* Fix issues

* Fix issues

* Fix placeholder value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

Assignees
No one assigned
Labels
backported Project:i18n Team:Monitoring Stack Monitoring team v6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nox911 @elasticmachine @maryia-lapata @chrisronline