Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[routes/setup] check that the defaultIndex exists #2425

Merged
merged 2 commits into from
Dec 22, 2014

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Dec 19, 2014

When looking for the default index pattern on route setup we stopped checking that it exists in elasticsearch. This restores that behavior.

defined = false;
}

if (defined) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be !defined?

@w33ble
Copy link
Contributor

w33ble commented Dec 19, 2014

It would be nice if there was a message on the index pattern screen explaining that a default should be defined. Currently, it just looks like you don't have any defined yet - here, I have 2, but no default.

screenshot 2014-12-19 15 42 10

@w33ble w33ble assigned spalger and unassigned w33ble Dec 19, 2014
@spalger spalger assigned w33ble and unassigned spalger Dec 22, 2014
w33ble added a commit that referenced this pull request Dec 22, 2014
…istance

[routes/setup] check that the defaultIndex exists
@w33ble w33ble merged commit 014ff76 into elastic:master Dec 22, 2014
@spalger spalger deleted the check_for_default_index_existance branch February 9, 2015 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants