-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting cookies #24177
Reporting cookies #24177
Changes from all commits
57b4fb8
e340fa6
b656c78
4a029c4
a1ffe12
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,6 +26,7 @@ | |
"@kbn/plugin-helpers": "link:../packages/kbn-plugin-helpers", | ||
"@kbn/test": "link:../packages/kbn-test", | ||
"@types/angular": "^1.6.50", | ||
"@types/cookie": "^0.3.1", | ||
"@types/d3-array": "^1.2.1", | ||
"@types/d3-scale": "^2.0.0", | ||
"@types/d3-shape": "^1.2.2", | ||
|
@@ -147,6 +148,7 @@ | |
"chroma-js": "^1.3.6", | ||
"classnames": "2.2.5", | ||
"concat-stream": "1.5.1", | ||
"cookie": "^0.3.1", | ||
"copy-to-clipboard": "^3.0.8", | ||
"d3": "3.5.6", | ||
"d3-scale": "1.0.6", | ||
|
@@ -170,6 +172,7 @@ | |
"humps": "2.0.1", | ||
"icalendar": "0.7.1", | ||
"inline-style": "^2.0.0", | ||
"iron": "4", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's make sure @joshdover is aware of this, so that it lines up with the version we are requesting in the hapi upgrade (just in case it changed, I'm not sure if it has or not) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will likely need to be bumped with the hapi upgrade, even though the newer version is "wire compatible" and should serialize/deserialize the same. |
||
"isomorphic-fetch": "2.2.1", | ||
"joi": "6.10.1", | ||
"jquery": "^3.3.1", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`throw an Error if the objectType, savedObjectId and relativeUrls are provided 1`] = `"objectType and savedObjectId should not be provided in addition to the relativeUrls"`; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`headers it fails if it can't decrypt the headers 1`] = `"Failed to decrypt report job data. Please re-generate this report."`; | ||
|
||
exports[`sessionCookie it fails if it can't decrypt the session 1`] = `"Failed to decrypt report job data. Please re-generate this report."`; | ||
|
||
exports[`sessionCookie it throws error if cookie name can't be determined 1`] = `"Unable to determine the session cookie name"`; | ||
|
||
exports[`urls it throw error if full URL is provided that is not a Kibana URL 1`] = `"Unable to generate report for url https://localhost/app/kibana, it's not a Kibana URL"`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised we haven't needed to do any cookie parsing up until this point. I assume that HAPI doesn't provide any facilities for this that we can use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to find any unfortunately...