Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beats CM] Fix beat list redirect to welcome page #24146

Conversation

justinkambic
Copy link
Contributor

Summary

At the moment, the search bar on the beats list page will redirect the user if the filter endpoint returns an empty set:

oct-17-2018 10-46-40

This change adds a new state field, unfilteredBeats, that contains all the beats. The logic for determining when to redirect now checks this field instead of the beats field, which is subject to filtering.

oct-17-2018 10-47-28

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic justinkambic changed the title [Beats CM] Fix inappropriate redirect to welcome page [Beats CM] Fix beat list redirect to welcome page Oct 17, 2018
@justinkambic justinkambic merged commit d0f0557 into elastic:feature/x-pack/management/beats Oct 17, 2018
@justinkambic justinkambic deleted the beatsCM_fix-autocomplete-field-incorrect-redirect branch October 17, 2018 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants