[Beats CM] Add Search component for table assignment options #23202
Conversation
💔 Build Failed |
💔 Build Failed |
justinkambic
force-pushed
the
ui/add-search-assignment-control
branch
from
282a90d to
213bea5
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
Just saw this, sorry. We allow the user to add some tag to all selected beats in the beats list. This would add another way of doing that from this view, is it really needed? |
|
@exekias - my motivation for these changes is reasoned that, while there aren't likely to be thousands of tags in a configuration index, there could very well be thousands of beats. The present control simply This would replace that solution. If we want to go another direction, or remove the ability to assign beats to a tag entirely, that's doable as well. I felt that this was a better placeholder than what's currently in the feature branch today. |
|
thank you for the explanation, that makes sense. I wonder if we should go with the later, removing this functionality. That would mean that you need to go to the beats tab to assign a tag, which is not that bad. What do you think? |
|
@exekias I am fine with removing assignment options from this table if you and @mattapperson agree it is ok. I can modify these changes to exclude assignment options on this table. |
|
SGTM, thanks! |
|
Closing this PR in favor of #23663, which better addresses the issues these changes attempted to solve. |
Changes
We've talked about abandoning the ability to assign beats and tags to one another from the table because the options we were using are not scalable for large numbers of beats/tags. I've added a new component for the assignment section. At the moment it's only doing exact matches for one beat, but it could be customized to do an exact or fuzzy search to find a set of beats.
Additionally, the way assignment components are defined has changed, and is set up to handle a variety of components in a generic way.