Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Beats CM] Sort beat list tags #22729

Merged
merged 2 commits into from
Sep 7, 2018
Merged

[Beats CM] Sort beat list tags #22729

merged 2 commits into from
Sep 7, 2018

Conversation

justinkambic
Copy link
Contributor

Changes

There's no sorting of tags in the Beats List at the moment. If you add/remove tags, they will be rendered in chronological order rather than alphabetically, which is jarring.

sep-05-2018 13-32-05

After Changes

sep-05-2018 13-34-27

Testing

To verify these changes:

  • Enroll several beats
  • Create several tags
  • Associate the alphabetically-highest (i.e. Test in ["Production", "Test"] tag with a beat(s)
  • Associate a lower tag. Ensure that the tags are shown as "Production" "Test"

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic justinkambic mentioned this pull request Sep 6, 2018
Merged
@justinkambic justinkambic merged commit 6ecce0f into elastic:feature/x-pack/management/beats Sep 7, 2018
@justinkambic justinkambic deleted the ui/sort-beat-list-tags-before-render branch September 7, 2018 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattapperson mattapperson mattapperson approved these changes

Assignees
No one assigned
Labels
Feature:beats-cm Team:Beats v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkambic @elasticmachine @mattapperson