Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #22579, Kibana fails to use the latest Chromium build #22580

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Fix #22579, Kibana fails to use the latest Chromium build #22580

merged 1 commit into from
Aug 31, 2018

Conversation

chrisdavies
Copy link
Contributor

We recently updated Chromium, and in some environments, Kibana was still using the old Chromium binaries. This PR fixes that bug.

@chrisdavies chrisdavies added Team:Monitoring Stack Monitoring team (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v6.5.0 v7.0.0 labels Aug 31, 2018
@stacey-gammon stacey-gammon added :Sharing and removed Team:Monitoring Stack Monitoring team labels Aug 31, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Contributor

retest

looks unrelated

stacey-gammon
stacey-gammon approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pull down and confirmed that it didn't extract when my binary matched the checksum, but did when it didn't

@chrisdavies
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisdavies chrisdavies merged commit 8a930f2 into elastic:master Aug 31, 2018
chrisdavies added a commit to chrisdavies/kibana that referenced this pull request Aug 31, 2018
@chrisdavies
Fix elastic#22579 (elastic#22580)
3535870
@chrisdavies chrisdavies mentioned this pull request Aug 31, 2018
Merged
chrisdavies added a commit that referenced this pull request Aug 31, 2018
@chrisdavies
Fix #22579 (#22580) (#22600)
520bdf0
@chrisdavies chrisdavies deleted the reporting/22579-extract-browsers branch August 31, 2018 18:13
kobelb pushed a commit to kobelb/kibana that referenced this pull request Oct 30, 2018
@chrisdavies @kobelb
Fix elastic#22579 (elastic#22580) (elastic#22600)
9c34306
kobelb added a commit that referenced this pull request Oct 30, 2018
@kobelb
[6.4] Reporting Cookies #24752 (#24794)
968768f 
* Revert "[6.4] Reporting cookies (#24177) (#24236)"

This reverts commit 7bac28b.

* Take 2

* Fixing yarn.lock

* Fix #22579 (#22580) (#22600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdavies @elasticmachine @stacey-gammon