Beats/security #22500
Merged
Beats/security #22500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
|
To functionally test, should I try to access Beats CM while running a trial vs basic license, and then run a snapshot with gold added, and try security as well? Plan
|
justinkambic
requested changes
Aug 29, 2018
|
|
||
| private checkLicense(xPackInfo: any) { | ||
| // If, for some reason, we cannot get the license information | ||
| // from Elasticsearch, assume worst case and disable the Logstash pipeline UI |
| securityEnabled: false, | ||
| licenseValid: false, | ||
| message: | ||
| 'You cannot manage Beats centeral management because license information is not available at this time.', |
There was a problem hiding this comment.
Can we update this language to say
You cannot use Beats Central Management because license information is not available at this time.
|
Functionally this looks good to me, provided you don't need me to test anything beyond what I've already outlined above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a license check system to beats management.
Routes now have an extra option of
licenseRequired.UI now is enabled/disabled based on one of 2 factors:
The only route that returns a non-error if no valid license is the get configs route