[Security Solution] [AI Assistant] Remove citations feature flag #212204
+151
−386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
KDKHD
added
release_note:skip
KDKHD
changed the title
….com:KDKHD/kibana into enhancement/remove_citation_feature_flag
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
Page load bundle
History
|
botelastic
bot
added
the
Team:Fleet
KDKHD
force-pushed
the
enhancement/remove_citation_feature_flag
branch
from
579c184 to
37359cb
Compare
KDKHD
force-pushed
the
enhancement/remove_citation_feature_flag
branch
from
37359cb to
baff833
Compare
stephmilovic
approved these changes
Feb 25, 2025
|
Starting backport for target branches: 8.18, 9.0 https://github.com/elastic/kibana/actions/runs/13525145967 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 25, 2025
…stic#212204) ## Summary Removes the citations feature flag added in this PR: elastic#206683 #### How to test: - Add the feature flag to kibana.dev.yaml `xpack.securitySolution.enableExperimental: ['contentReferencesEnabled']` - Start Kibana - You should see the log ``` The following configuration values are no longer supported and should be removed from the kibana configuration file: xpack.securitySolution.enableExperimental: - contentReferencesEnabled ``` - Remove the feature flag from kibana.dev.yaml - Restart Kibana - You should not see the log - Open the Security AI assistant - Check "Show citations" exists in the assistant settings menu <img width="869" alt="image" src="https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951" /> - Ask the assistant a question about your knowledge base or an alert. The response should contain a citation. (if it does not, append "include citations" to your prompt) - Use the shortcut option + c to toggle citations on and off. Observe if this works as expected. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 638ae14)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
KDKHD
added a commit
to KDKHD/kibana
that referenced
this pull request
Feb 25, 2025
…stic#212204) ## Summary Removes the citations feature flag added in this PR: elastic#206683 #### How to test: - Add the feature flag to kibana.dev.yaml `xpack.securitySolution.enableExperimental: ['contentReferencesEnabled']` - Start Kibana - You should see the log ``` The following configuration values are no longer supported and should be removed from the kibana configuration file: xpack.securitySolution.enableExperimental: - contentReferencesEnabled ``` - Remove the feature flag from kibana.dev.yaml - Restart Kibana - You should not see the log - Open the Security AI assistant - Check "Show citations" exists in the assistant settings menu <img width="869" alt="image" src="https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951" /> - Ask the assistant a question about your knowledge base or an alert. The response should contain a citation. (if it does not, append "include citations" to your prompt) - Use the shortcut option + c to toggle citations on and off. Observe if this works as expected. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 638ae14) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/capabilities/index.ts # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/settings/settings_context_menu/settings_context_menu.tsx
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2025
#212204) (#212400) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] [AI Assistant] Remove citations feature flag (#212204)](#212204) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kenneth Kreindler","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-25T15:42:29Z","message":"[Security Solution] [AI Assistant] Remove citations feature flag (#212204)\n\n## Summary\n\nRemoves the citations feature flag added in this PR:\nhttps://github.com//pull/206683\n\n#### How to test:\n- Add the feature flag to kibana.dev.yaml\n`xpack.securitySolution.enableExperimental:\n['contentReferencesEnabled']`\n- Start Kibana\n- You should see the log \n```\nThe following configuration values are no longer supported and should be removed from the kibana configuration file:\n\n xpack.securitySolution.enableExperimental:\n - contentReferencesEnabled\n```\n- Remove the feature flag from kibana.dev.yaml\n- Restart Kibana\n- You should not see the log\n- Open the Security AI assistant\n- Check \"Show citations\" exists in the assistant settings menu\n<img width=\"869\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951\"\n/>\n\n- Ask the assistant a question about your knowledge base or an alert.\nThe response should contain a citation. (if it does not, append \"include\ncitations\" to your prompt)\n- Use the shortcut option + c to toggle citations on and off. Observe if\nthis works as expected.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"638ae14772149ce7cb7ec8baf1430cb4f449fdf9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Security Generative AI","backport:version","v8.18.0","v9.1.0"],"title":"[Security Solution] [AI Assistant] Remove citations feature flag","number":212204,"url":"https://github.com/elastic/kibana/pull/212204","mergeCommit":{"message":"[Security Solution] [AI Assistant] Remove citations feature flag (#212204)\n\n## Summary\n\nRemoves the citations feature flag added in this PR:\nhttps://github.com//pull/206683\n\n#### How to test:\n- Add the feature flag to kibana.dev.yaml\n`xpack.securitySolution.enableExperimental:\n['contentReferencesEnabled']`\n- Start Kibana\n- You should see the log \n```\nThe following configuration values are no longer supported and should be removed from the kibana configuration file:\n\n xpack.securitySolution.enableExperimental:\n - contentReferencesEnabled\n```\n- Remove the feature flag from kibana.dev.yaml\n- Restart Kibana\n- You should not see the log\n- Open the Security AI assistant\n- Check \"Show citations\" exists in the assistant settings menu\n<img width=\"869\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951\"\n/>\n\n- Ask the assistant a question about your knowledge base or an alert.\nThe response should contain a citation. (if it does not, append \"include\ncitations\" to your prompt)\n- Use the shortcut option + c to toggle citations on and off. Observe if\nthis works as expected.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"638ae14772149ce7cb7ec8baf1430cb4f449fdf9"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212204","number":212204,"mergeCommit":{"message":"[Security Solution] [AI Assistant] Remove citations feature flag (#212204)\n\n## Summary\n\nRemoves the citations feature flag added in this PR:\nhttps://github.com//pull/206683\n\n#### How to test:\n- Add the feature flag to kibana.dev.yaml\n`xpack.securitySolution.enableExperimental:\n['contentReferencesEnabled']`\n- Start Kibana\n- You should see the log \n```\nThe following configuration values are no longer supported and should be removed from the kibana configuration file:\n\n xpack.securitySolution.enableExperimental:\n - contentReferencesEnabled\n```\n- Remove the feature flag from kibana.dev.yaml\n- Restart Kibana\n- You should not see the log\n- Open the Security AI assistant\n- Check \"Show citations\" exists in the assistant settings menu\n<img width=\"869\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951\"\n/>\n\n- Ask the assistant a question about your knowledge base or an alert.\nThe response should contain a citation. (if it does not, append \"include\ncitations\" to your prompt)\n- Use the shortcut option + c to toggle citations on and off. Observe if\nthis works as expected.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"638ae14772149ce7cb7ec8baf1430cb4f449fdf9"}}]}] BACKPORT--> Co-authored-by: Kenneth Kreindler <[email protected]>
KDKHD
added a commit
that referenced
this pull request
Feb 25, 2025
…ag (#212204) (#212418) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] [AI Assistant] Remove citations feature flag (#212204)](#212204) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kenneth Kreindler","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-25T15:42:29Z","message":"[Security Solution] [AI Assistant] Remove citations feature flag (#212204)\n\n## Summary\n\nRemoves the citations feature flag added in this PR:\nhttps://github.com//pull/206683\n\n#### How to test:\n- Add the feature flag to kibana.dev.yaml\n`xpack.securitySolution.enableExperimental:\n['contentReferencesEnabled']`\n- Start Kibana\n- You should see the log \n```\nThe following configuration values are no longer supported and should be removed from the kibana configuration file:\n\n xpack.securitySolution.enableExperimental:\n - contentReferencesEnabled\n```\n- Remove the feature flag from kibana.dev.yaml\n- Restart Kibana\n- You should not see the log\n- Open the Security AI assistant\n- Check \"Show citations\" exists in the assistant settings menu\n<img width=\"869\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951\"\n/>\n\n- Ask the assistant a question about your knowledge base or an alert.\nThe response should contain a citation. (if it does not, append \"include\ncitations\" to your prompt)\n- Use the shortcut option + c to toggle citations on and off. Observe if\nthis works as expected.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"638ae14772149ce7cb7ec8baf1430cb4f449fdf9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Security Generative AI","backport:version","v8.18.0","v9.1.0"],"title":"[Security Solution] [AI Assistant] Remove citations feature flag","number":212204,"url":"https://github.com/elastic/kibana/pull/212204","mergeCommit":{"message":"[Security Solution] [AI Assistant] Remove citations feature flag (#212204)\n\n## Summary\n\nRemoves the citations feature flag added in this PR:\nhttps://github.com//pull/206683\n\n#### How to test:\n- Add the feature flag to kibana.dev.yaml\n`xpack.securitySolution.enableExperimental:\n['contentReferencesEnabled']`\n- Start Kibana\n- You should see the log \n```\nThe following configuration values are no longer supported and should be removed from the kibana configuration file:\n\n xpack.securitySolution.enableExperimental:\n - contentReferencesEnabled\n```\n- Remove the feature flag from kibana.dev.yaml\n- Restart Kibana\n- You should not see the log\n- Open the Security AI assistant\n- Check \"Show citations\" exists in the assistant settings menu\n<img width=\"869\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951\"\n/>\n\n- Ask the assistant a question about your knowledge base or an alert.\nThe response should contain a citation. (if it does not, append \"include\ncitations\" to your prompt)\n- Use the shortcut option + c to toggle citations on and off. Observe if\nthis works as expected.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"638ae14772149ce7cb7ec8baf1430cb4f449fdf9"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/212400","number":212400,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212204","number":212204,"mergeCommit":{"message":"[Security Solution] [AI Assistant] Remove citations feature flag (#212204)\n\n## Summary\n\nRemoves the citations feature flag added in this PR:\nhttps://github.com//pull/206683\n\n#### How to test:\n- Add the feature flag to kibana.dev.yaml\n`xpack.securitySolution.enableExperimental:\n['contentReferencesEnabled']`\n- Start Kibana\n- You should see the log \n```\nThe following configuration values are no longer supported and should be removed from the kibana configuration file:\n\n xpack.securitySolution.enableExperimental:\n - contentReferencesEnabled\n```\n- Remove the feature flag from kibana.dev.yaml\n- Restart Kibana\n- You should not see the log\n- Open the Security AI assistant\n- Check \"Show citations\" exists in the assistant settings menu\n<img width=\"869\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951\"\n/>\n\n- Ask the assistant a question about your knowledge base or an alert.\nThe response should contain a citation. (if it does not, append \"include\ncitations\" to your prompt)\n- Use the shortcut option + c to toggle citations on and off. Observe if\nthis works as expected.\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"638ae14772149ce7cb7ec8baf1430cb4f449fdf9"}}]}] BACKPORT-->
KDKHD
added a commit
to KDKHD/kibana
that referenced
this pull request
Feb 26, 2025
…stic#212204) ## Summary Removes the citations feature flag added in this PR: elastic#206683 #### How to test: - Add the feature flag to kibana.dev.yaml `xpack.securitySolution.enableExperimental: ['contentReferencesEnabled']` - Start Kibana - You should see the log ``` The following configuration values are no longer supported and should be removed from the kibana configuration file: xpack.securitySolution.enableExperimental: - contentReferencesEnabled ``` - Remove the feature flag from kibana.dev.yaml - Restart Kibana - You should not see the log - Open the Security AI assistant - Check "Show citations" exists in the assistant settings menu <img width="869" alt="image" src="https://github.com/user-attachments/assets/34a4c812-bccd-4eef-a9f9-7c834faff951" /> - Ask the assistant a question about your knowledge base or an alert. The response should contain a citation. (if it does not, append "include citations" to your prompt) - Use the shortcut option + c to toggle citations on and off. Observe if this works as expected. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 638ae14) # Conflicts: # x-pack/platform/packages/shared/kbn-elastic-assistant-common/impl/capabilities/index.ts # x-pack/platform/packages/shared/kbn-elastic-assistant/impl/assistant/settings/settings_context_menu/settings_context_menu.tsx # x-pack/solutions/security/plugins/elastic_assistant/server/ai_assistant_data_clients/knowledge_base/helpers.ts # x-pack/solutions/security/plugins/elastic_assistant/server/ai_assistant_data_clients/knowledge_base/index.ts # x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/executors/types.ts # x-pack/solutions/security/plugins/elastic_assistant/server/routes/chat/chat_complete_route.ts # x-pack/solutions/security/plugins/elastic_assistant/server/routes/evaluate/post_evaluate.ts # x-pack/solutions/security/plugins/elastic_assistant/server/routes/helpers.ts # x-pack/solutions/security/plugins/elastic_assistant/server/routes/post_actions_connector_execute.ts # x-pack/solutions/security/plugins/security_solution/server/assistant/tools/alert_counts/alert_counts_tool.test.ts # x-pack/solutions/security/plugins/security_solution/server/assistant/tools/knowledge_base/knowledge_base_retrieval_tool.test.ts # x-pack/solutions/security/plugins/security_solution/server/assistant/tools/open_and_acknowledged_alerts/open_and_acknowledged_alerts_tool.test.ts # x-pack/solutions/security/plugins/security_solution/server/assistant/tools/product_docs/product_documentation_tool.test.ts # x-pack/solutions/security/plugins/security_solution/server/assistant/tools/security_labs/security_labs_tool.test.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the citations feature flag added in this PR: #206683
How to test:
xpack.securitySolution.enableExperimental: ['contentReferencesEnabled']Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.