Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] script_fields now available in field dropdowns of the advanced wizard's detectors modal. #21205

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 25, 2018

Fixes #18689. Part of #18368.

If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal.

Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.

The following screenshot shows the scripted field lat-lon for the field_name dropdown using the job configuration from #18689, previously, it wouldn't show up.

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic changed the title [ML] script_fields now available in field dropdowns of the advanced wirzard's detectors modal. [ML] script_fields now available in field dropdowns of the advanced wizard's detectors modal. Jul 25, 2018
@walterra walterra added the bug Fixes for quality problems that affect the customer experience label Jul 25, 2018
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@walterra
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit d4efed5 into elastic:master Jul 25, 2018
walterra added a commit to walterra/kibana that referenced this pull request Jul 25, 2018
…d's detectors modal. (elastic#21205)

- If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal.
- Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.
walterra added a commit to walterra/kibana that referenced this pull request Jul 25, 2018
…d's detectors modal. (elastic#21205)

- If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal.
- Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.
@walterra walterra deleted the ml-advanced-job-script-fields-ui branch July 25, 2018 16:53
walterra added a commit that referenced this pull request Jul 26, 2018
…d's detectors modal. (#21205) (#21230)

- If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal.
- Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.
walterra added a commit that referenced this pull request Jul 26, 2018
…d's detectors modal. (#21205) (#21231)

- If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal.
- Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.
@walterra walterra changed the title [ML] script_fields now available in field dropdowns of the advanced wizard's detectors modal. [ML] Make script_fields now available in field dropdowns of the advanced wizard's detectors modal. Jul 26, 2018
@walterra walterra changed the title [ML] Make script_fields now available in field dropdowns of the advanced wizard's detectors modal. [ML] script_fields now available in field dropdowns of the advanced wizard's detectors modal. Jul 26, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml v6.4.0 v6.5.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants