-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] script_fields now available in field dropdowns of the advanced wizard's detectors modal. #21205
Merged
walterra
merged 1 commit into
elastic:master
from
walterra:ml-advanced-job-script-fields-ui
Jul 25, 2018
Merged
[ML] script_fields now available in field dropdowns of the advanced wizard's detectors modal. #21205
walterra
merged 1 commit into
elastic:master
from
walterra:ml-advanced-job-script-fields-ui
Jul 25, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d's detectors modal.
Pinging @elastic/ml-ui |
19 tasks
jgowdyelastic
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
peteharverson
approved these changes
Jul 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Build Failed |
retest |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 25, 2018
…d's detectors modal. (elastic#21205) - If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal. - Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jul 25, 2018
…d's detectors modal. (elastic#21205) - If a job configuration's datafeed contains script_fields, they are now available in the field dropdowns of the advanced wizard's detector modal. - Additionally, job validation now considers script_fields and doesn't report them as non aggregatable anymore.
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18689. Part of #18368.
If a job configuration's datafeed contains
script_fields
, they are now available in the field dropdowns of the advanced wizard's detector modal.Additionally, job validation now considers
script_fields
and doesn't report them as non aggregatable anymore.The following screenshot shows the scripted field
lat-lon
for thefield_name
dropdown using the job configuration from #18689, previously, it wouldn't show up.