Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating preconfigured connector name #211927

Conversation

Samiul-TheSoccerFan
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan commented Feb 20, 2025

Summary

Update Preconfigured connector name to Elastic LLM.

Screenshot 2025-02-20 at 11 29 02 AM

ES3 Testing instruction

No additional config needed. Once run in local machine, the changes should reflect automatically.

ESS instructions

In kibana.dev.yml file, add

# xpack.actions.preconfigured:
   Elastic-LLM:
     name: Elastic LLM
     actionTypeId: .inference
     exposeConfig: true
     config:
       provider: 'elastic'
       taskType: 'chat_completion'
       inferenceId: '.rainbow-sprinkles-elastic'
       providerConfig:
         model_id: 'rainbow-sprinkles'

and the preconfigured endpoint with updated name should be visible.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@Samiul-TheSoccerFan Samiul-TheSoccerFan added v8.18.0 v9.1.0 v8.19.0 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.0.0 labels Feb 20, 2025
@Samiul-TheSoccerFan Samiul-TheSoccerFan marked this pull request as ready for review February 20, 2025 17:41
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested review from a team as code owners February 20, 2025 17:41
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 20, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security engineering productivity changes LGTM

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM 🚀

@Samiul-TheSoccerFan Samiul-TheSoccerFan added the ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project label Feb 20, 2025
@kc13greiner kc13greiner self-requested a review February 20, 2025 18:43
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested a review from a team as a code owner February 20, 2025 19:15
@paul-tavares paul-tavares requested review from joeypoon and removed request for paul-tavares February 20, 2025 19:17
@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the update-preconfigured-connector-name branch from d4d80a0 to 757a1bd Compare February 20, 2025 19:19
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stateful-local: works as described in the Testing Instructions

serverless-local: I do no know what additional config is needed for it to show up

@Samiul-TheSoccerFan
Copy link
Contributor Author

@elasticmachine merge upstream

@Samiul-TheSoccerFan Samiul-TheSoccerFan force-pushed the update-preconfigured-connector-name branch from 8810b30 to e1213b9 Compare February 24, 2025 17:04
@Samiul-TheSoccerFan Samiul-TheSoccerFan requested review from YulNaumenko and removed request for joeypoon February 24, 2025 17:04
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samiul-TheSoccerFan
Copy link
Contributor Author

@YulNaumenko removed inferenceConnectorOff from Serverless yml file. Also, Locally, I do see the updated connector but the inference endpoint does not show up. Is it expected?

Screenshot 2025-02-25 at 12 00 46 PM
Screenshot 2025-02-25 at 12 00 59 PM

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 25, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@Samiul-TheSoccerFan Samiul-TheSoccerFan merged commit 0e02a32 into elastic:main Feb 25, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13529243457

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.18 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 211927

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 25, 2025
## Summary

Update Preconfigured connector name to `Elastic LLM`.

<img width="1504" alt="Screenshot 2025-02-20 at 11 29 02 AM"
src="https://github.com/user-attachments/assets/aa0a32f7-f1b2-4496-8c2e-7773f017c153"
/>

### ES3 Testing instruction
No additional config needed. Once run in local machine, the changes
should reflect automatically.

### ESS instructions
In `kibana.dev.yml` file, add
```
# xpack.actions.preconfigured:
   Elastic-LLM:
     name: Elastic LLM
     actionTypeId: .inference
     exposeConfig: true
     config:
       provider: 'elastic'
       taskType: 'chat_completion'
       inferenceId: '.rainbow-sprinkles-elastic'
       providerConfig:
         model_id: 'rainbow-sprinkles'
```
and the preconfigured endpoint with updated name should be visible.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0e02a32)

# Conflicts:
#	config/serverless.yml
#	x-pack/solutions/security/plugins/security_solution/public/management/cypress/tasks/insights.ts
Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 25, 2025
## Summary

Update Preconfigured connector name to `Elastic LLM`.

<img width="1504" alt="Screenshot 2025-02-20 at 11 29 02 AM"
src="https://github.com/user-attachments/assets/aa0a32f7-f1b2-4496-8c2e-7773f017c153"
/>

### ES3 Testing instruction
No additional config needed. Once run in local machine, the changes
should reflect automatically.

### ESS instructions
In `kibana.dev.yml` file, add
```
# xpack.actions.preconfigured:
   Elastic-LLM:
     name: Elastic LLM
     actionTypeId: .inference
     exposeConfig: true
     config:
       provider: 'elastic'
       taskType: 'chat_completion'
       inferenceId: '.rainbow-sprinkles-elastic'
       providerConfig:
         model_id: 'rainbow-sprinkles'
```
and the preconfigured endpoint with updated name should be visible.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0e02a32)

# Conflicts:
#	config/serverless.yml
#	x-pack/solutions/security/plugins/security_solution/public/management/cypress/tasks/insights.ts
@Samiul-TheSoccerFan
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
9.0
8.x
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Samiul-TheSoccerFan added a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Feb 25, 2025
## Summary

Update Preconfigured connector name to `Elastic LLM`.

<img width="1504" alt="Screenshot 2025-02-20 at 11 29 02 AM"
src="https://github.com/user-attachments/assets/aa0a32f7-f1b2-4496-8c2e-7773f017c153"
/>

### ES3 Testing instruction
No additional config needed. Once run in local machine, the changes
should reflect automatically.

### ESS instructions
In `kibana.dev.yml` file, add
```
# xpack.actions.preconfigured:
   Elastic-LLM:
     name: Elastic LLM
     actionTypeId: .inference
     exposeConfig: true
     config:
       provider: 'elastic'
       taskType: 'chat_completion'
       inferenceId: '.rainbow-sprinkles-elastic'
       providerConfig:
         model_id: 'rainbow-sprinkles'
```
and the preconfigured endpoint with updated name should be visible.

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0e02a32)

# Conflicts:
#	config/serverless.yml
#	x-pack/solutions/security/plugins/security_solution/public/management/cypress/tasks/insights.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants