[scout] enable eslint plugin playwright #210666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-plugin-playwright
dmlemeshko
added
release_note:skip
mykolaharmash
approved these changes
Feb 12, 2025
Ikuni17
approved these changes
Feb 13, 2025
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @dmlemeshko |
|
Starting backport for target branches: 8.x, 9.0 https://github.com/elastic/kibana/actions/runs/13326217262 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 14, 2025
## Summary Closes elastic#21030 It was a quick work to do while we don't have many tests yet. For reviewers: we most likely will review and update the rules to align better with final test design for Scout before GA. I don't think we have to deep dive into what rules are missing, but just to make sure I didn't restrict something important from your perspective. Rules are described in https://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#rules --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit ddd0fdb)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 14, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[scout] enable eslint plugin playwright (#210666)](#210666) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-14T09:21:49Z","message":"[scout] enable eslint plugin playwright (#210666)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/21030\r\n\r\nIt was a quick work to do while we don't have many tests yet. \r\n\r\nFor reviewers: we most likely will review and update the rules to align\r\nbetter with final test design for Scout before GA. I don't think we have\r\nto deep dive into what rules are missing, but just to make sure I didn't\r\nrestrict something important from your perspective.\r\n\r\nRules are described in\r\nhttps://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#rules\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"ddd0fdb4794b71f7c500f5d7d03a846bf21174b9","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","test:scout","v9.1.0","v8.19.0"],"title":"[scout] enable eslint plugin playwright","number":210666,"url":"https://github.com/elastic/kibana/pull/210666","mergeCommit":{"message":"[scout] enable eslint plugin playwright (#210666)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/21030\r\n\r\nIt was a quick work to do while we don't have many tests yet. \r\n\r\nFor reviewers: we most likely will review and update the rules to align\r\nbetter with final test design for Scout before GA. I don't think we have\r\nto deep dive into what rules are missing, but just to make sure I didn't\r\nrestrict something important from your perspective.\r\n\r\nRules are described in\r\nhttps://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#rules\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"ddd0fdb4794b71f7c500f5d7d03a846bf21174b9"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210666","number":210666,"mergeCommit":{"message":"[scout] enable eslint plugin playwright (#210666)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/21030\r\n\r\nIt was a quick work to do while we don't have many tests yet. \r\n\r\nFor reviewers: we most likely will review and update the rules to align\r\nbetter with final test design for Scout before GA. I don't think we have\r\nto deep dive into what rules are missing, but just to make sure I didn't\r\nrestrict something important from your perspective.\r\n\r\nRules are described in\r\nhttps://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#rules\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"ddd0fdb4794b71f7c500f5d7d03a846bf21174b9"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <[email protected]>
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #210300
It was a quick work to do while we don't have many tests yet.
For reviewers: we most likely will review and update the rules to align better with final test design for Scout before GA. I don't think we have to deep dive into what rules are missing, but just to make sure I didn't restrict something important from your perspective.
Rules are described in https://github.com/playwright-community/eslint-plugin-playwright?tab=readme-ov-file#rules