[Discover Session] Fix "Untitled" export title when exporting CSV on a dashboard #210143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
Feature:Discover
|
/ci |
|
/ci |
|
/ci |
kertal
added
the
backport:prev-major
kertal
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Feb 11, 2025
.../packages/private/kbn-reporting/get_csv_panel_actions/panel_actions/get_csv_panel_action.tsx
Outdated
Show resolved
Hide resolved
Dosant
approved these changes
Feb 12, 2025
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x https://github.com/elastic/kibana/actions/runs/13290062622 |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @kertal |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…a dashboard (elastic#210143) - Fixes "Untitled" CSV exports when an export of a Discover session CSV is triggered on a Dashboard - Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard. (cherry picked from commit 7a72b14)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…a dashboard (elastic#210143) - Fixes "Untitled" CSV exports when an export of a Discover session CSV is triggered on a Dashboard - Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard. (cherry picked from commit 7a72b14)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…a dashboard (elastic#210143) - Fixes "Untitled" CSV exports when an export of a Discover session CSV is triggered on a Dashboard - Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard. (cherry picked from commit 7a72b14)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…a dashboard (elastic#210143) - Fixes "Untitled" CSV exports when an export of a Discover session CSV is triggered on a Dashboard - Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard. (cherry picked from commit 7a72b14)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…xporting CSV on a dashboard (#210143) (#210883) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover Session] Fix "Untitled" export title when exporting CSV on a dashboard (#210143)](#210143) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T16:24:43Z","message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","backport:prev-major","v9.1.0"],"title":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard","number":210143,"url":"https://github.com/elastic/kibana/pull/210143","mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210143","number":210143,"mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…exporting CSV on a dashboard (#210143) (#210882) # Backport This will backport the following commits from `main` to `8.18`: - [[Discover Session] Fix "Untitled" export title when exporting CSV on a dashboard (#210143)](#210143) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T16:24:43Z","message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","backport:prev-major","v9.1.0"],"title":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard","number":210143,"url":"https://github.com/elastic/kibana/pull/210143","mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210143","number":210143,"mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
This was referenced Feb 13, 2025
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
3 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
@kertal Are we planning to merge the 8.16 and 8.17 backports, or should we close them and drop the labels? Asking because I keep getting pinged by @kibanamachine about it 😄 |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Yes, I'm ON it @davismcphee ... I just couldn't make it to them, 🙈 |
kibanamachine
added a commit
that referenced
this pull request
Feb 24, 2025
…exporting CSV on a dashboard (#210143) (#210881) # Backport This will backport the following commits from `main` to `8.17`: - [[Discover Session] Fix "Untitled" export title when exporting CSV on a dashboard (#210143)](#210143) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T16:24:43Z","message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","backport:prev-major","v9.1.0"],"title":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard","number":210143,"url":"https://github.com/elastic/kibana/pull/210143","mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210143","number":210143,"mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}}]}] BACKPORT--> --------- Co-authored-by: Matthias Wilhelm <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 25, 2025
…exporting CSV on a dashboard (#210143) (#210880) # Backport This will backport the following commits from `main` to `8.16`: - [[Discover Session] Fix "Untitled" export title when exporting CSV on a dashboard (#210143)](#210143) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T16:24:43Z","message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","backport:prev-major","v9.1.0"],"title":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard","number":210143,"url":"https://github.com/elastic/kibana/pull/210143","mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210143","number":210143,"mergeCommit":{"message":"[Discover Session] Fix \"Untitled\" export title when exporting CSV on a dashboard (#210143)\n\n- Fixes \"Untitled\" CSV exports when an export of a Discover session CSV is triggered on a Dashboard\n- Switches to make use of the embeddable title when exporting CSV of Discover session embeddables on a Dashboard.","sha":"7a72b14fd5a032f6bcf5ad5d68f84d7e092a23c8"}}]}] BACKPORT--> --------- Co-authored-by: Matthias Wilhelm <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
added
v8.16.5
and removed
backport missing
|
✅ done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #206854
This PR
To make use of the embeddable title has the advantage that the export names can still be edited after a Discover session was unlinked and what's more several same saved sessions on a dashboard can have different named exports aligned with the embeddable title with this change.
Checklist