Upgrade ES client to 9.0.0-alpha.3 #208776
Conversation
# Conflicts: # x-pack/solutions/security/packages/data-stream-adapter/src/create_or_update_data_stream.ts # x-pack/solutions/security/packages/index-adapter/src/create_or_update_index.ts
afharo
force-pushed
the
es-9.0.0-alpha.2
branch
from
087452c to
640c0fd
Compare
afharo
force-pushed
the
es-9.0.0-alpha.2
branch
from
0561aa3 to
8c610c2
Compare
|
It looks like this PR modifies one or more |
afharo
changed the title
afharo
force-pushed
the
es-9.0.0-alpha.2
branch
from
45691d7 to
f5c6882
Compare
|
It looks like this PR modifies one or more |
| @@ -131,6 +131,7 @@ export function registerSearchApplicationsRoutes({ log, router }: RouteDependenc | |||
| name: request.params.engine_name, | |||
| search_application: { | |||
| indices: request.body.indices, | |||
| // @ts-expect-error [email protected] has this parameter been renamed to analytics_collection_name? | |||
There was a problem hiding this comment.
This actually a different one. name is the search application's display name, analytics_collection_name is the name of the related collection
https://github.com/elastic/elasticsearch/blob/main/x-pack/plugin/ent-search/src/main/java/org/elasticsearch/xpack/application/search/SearchApplication.java#L67
|
MKI tests passed! Running a final CI with the latest |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @afharo |
|
Starting backport for target branches: 9.0 https://github.com/elastic/kibana/actions/runs/13523771765 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
afharo
removed
the
backport:prev-minor
|
Skipping backport since the amount of conflicts in the 9.0 branch would create too many risks. |
Summary
Updating the ES client to 9.0.
Resolves #116102
What changes?
Breaking change:
bodyhas been removed.Most of the changes are about bringing all the content inside the body as a root attribute to the API params:
const response = await client.search({ index: 'test', - body: { query: { match_all: {} } - } })For this reason, enabling the "Hide whitespace changes" option when reviewing is recommended.
Some exceptions to this rule:
bodyarray withoperationsarray (direct replacement)bodyarray withsettings(direct replacement)bodyarray withsearchesarray (direct replacement)bodywithdocument(direct replacement)bodywithrepository(direct replacement)Because of a known issue in the client (elastic/elasticsearch-js#2584), there's still an escape hatch to send data in the body in case the specific use case requires it via
// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584, but it shouldn't be abused because we lose types. In this PR we've used it in those scenarios where we reuse the response of a GET as the body of a PUT/POST.Other changes
estypescan be imported from the root of the library asimport type { estypes } from '@elastic/elasticsearch';estypesWithBodyhave been removedrequestTimeout's 30s default has been removed in the client. This PR explicitly adds the setting in all client usages.Identify risks
bodyusage there via// @ts-expect-error [email protected] https://github.com/elastic/elasticsearch-js/issues/2584. The next version of the client will address this.