-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] New FTR for "view logs" link #208351
Open
consulthys
wants to merge
8
commits into
main
Choose a base branch
from
stack-mon-add-ftr-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…View logs" link is present
…ibana into stack-mon-add-ftr-logs
…View logs" link is present
…View logs" link is present
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @consulthys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Feature:Stack Monitoring
FTR
release_note:skip
Skip the PR/issue when compiling release notes
Team:Monitoring
Stack Monitoring team
v8.17.2
v8.18.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #202675
A recent bug broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation.
This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page.
Checklist