Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] New FTR for "view logs" link #208351

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

consulthys
Copy link
Contributor

Summary

Closes #202675

A recent bug broke the Stack Monitoring UI only if/when logs were present. Functional test coverage was lacking to detect such a situation.

This PR adds some functional test coverage to make sure that the "View logs" link in Stack Monitoring works whenever logs are available, wherever logs can be visible, i.e. in the cluster overview page, the node details page and the index details page.

Checklist

@consulthys consulthys self-assigned this Jan 27, 2025
@consulthys consulthys marked this pull request as ready for review January 29, 2025 12:16
@consulthys consulthys requested a review from a team as a code owner January 29, 2025 12:16
@consulthys consulthys added backport Team:Monitoring Stack Monitoring team Feature:Stack Monitoring v8.18.0 v8.17.2 release_note:skip Skip the PR/issue when compiling release notes FTR labels Jan 29, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 31, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Case Owner Selection renders all options
  • [job] [logs] Jest Tests #10 / Connector renders loading state correctly
  • [job] [logs] Jest Tests #10 / DeleteConfirmationModal calls onConfirm
  • [job] [logs] FTR Configs #101 / Monitoring app Elasticsearch overview should show the link to view more cluster logs
  • [job] [logs] FTR Configs #101 / Monitoring app Elasticsearch overview should show the link to view more cluster logs
  • [job] [logs] FTR Configs #2 / Monitoring Elasticsearch node detail should summarize node with metrics
  • [job] [logs] FTR Configs #2 / Monitoring Elasticsearch node detail should summarize node with metrics
  • [job] [logs] Jest Tests #10 / useGetCaseUsers shows a toast error when the api return an error

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 515.2KB 515.3KB +69.0B

History

cc @consulthys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Update functional tests to catch logs-related issues
2 participants