Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EUI visual refresh][Management] Background color fixes #208135

Merged
merged 1 commit into from
Jan 24, 2025
Merged

[EUI visual refresh][Management] Background color fixes #208135

merged 1 commit into from
Jan 24, 2025

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Jan 24, 2025 •
edited
Loading

Summary

Fixes the background color in two places. It was too dark before, now its not.

Ingest Pipelines -> Create/Edit pipeline
Screenshot 2025-01-23 at 9 48 22 PM

Index management -> Create/Edit index template AND Index management -> Create/Edit component template
Screenshot 2025-01-23 at 9 47 35 PM

Closes #208061

@mattkime mattkime self-assigned this Jan 24, 2025
@mattkime mattkime added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 24, 2025
@mattkime mattkime changed the title borealis fixes [EUI visual refresh][Management] Background color fixes Jan 24, 2025
@mattkime mattkime marked this pull request as ready for review January 24, 2025 04:11
@mattkime mattkime requested review from a team as code owners January 24, 2025 04:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / useDeleteAction deletes the selected cases

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 735.6KB 735.4KB -161.0B
ingestPipelines 419.8KB 419.7KB -156.0B
total -317.0B

cc @mattkime

jovana-andjelkovic
jovana-andjelkovic approved these changes Jan 24, 2025
View reviewed changes
Copy link

@jovana-andjelkovic jovana-andjelkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

SoniaSanzV
SoniaSanzV approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally, lgtm :)

plus: 7 scss lines less!! 🎉

@mattkime mattkime merged commit 114ab92 into elastic:main Jan 24, 2025
15 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
@mattkime @JoseLuisGJ
[EUI visual refresh][Management] Background color fixes (elastic#208135)
cd9ef5f 
## Summary

Fixes the background color in two places. It was too dark before, now
its not.

Ingest Pipelines -> Create/Edit pipeline
<img width="829" alt="Screenshot 2025-01-23 at 9 48 22 PM"
src="https://github.com/user-attachments/assets/1b0ee9b4-3e38-4d9d-b352-008ae6f38196"
/>


Index management -> Create/Edit index template AND Index management ->
Create/Edit component template
<img width="890" alt="Screenshot 2025-01-23 at 9 47 35 PM"
src="https://github.com/user-attachments/assets/a480db7d-466d-4a8d-ac32-158bb697f319"
/>


Closes elastic#208061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

@jovana-andjelkovic jovana-andjelkovic jovana-andjelkovic approved these changes

Assignees

@mattkime mattkime

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EUI visual refresh][Management] META issue for additional updates
5 participants
@mattkime @elasticmachine @jovana-andjelkovic @SoniaSanzV @kibanamachine