Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message for manual rule run Modal window #208072

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Update message for manual rule run Modal window #208072

merged 2 commits into from
Jan 27, 2025

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Jan 23, 2025 •
edited by kibanamachine
Loading

Summary

Update message, that currently not support only 1 action type
Screenshot 2025-01-23 at 15 51 10

@nkhristinin nkhristinin requested a review from a team as a code owner January 23, 2025 14:57
@nkhristinin nkhristinin requested a review from vitaliidm January 23, 2025 14:57
@nkhristinin nkhristinin added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Jan 23, 2025
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin enabled auto-merge (squash) January 27, 2025 08:10
@nkhristinin nkhristinin merged commit bfddf6c into elastic:main Jan 27, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12986824718

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #21 / HoverableAvatar renders the tooltip when hovering
  • [job] [logs] Jest Tests #10 / Policy Advanced Settings section should expand and collapse section when button is clicked

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.3MB 21.3MB +45.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 27, 2025
@nkhristinin
Update message for manual rule run Modal window (elastic#208072)
a9923c0 
## Summary

Update message, that currently not support only 1 action type
<img width="670" alt="Screenshot 2025-01-23 at 15 51 10"
src="https://github.com/user-attachments/assets/758a5052-303d-4155-8320-e4c3e620c496"
/>

(cherry picked from commit bfddf6c)
@kibanamachine kibanamachine mentioned this pull request Jan 27, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 27, 2025
@kibanamachine @nkhristinin
[8.x] Update message for manual rule run Modal window (#208072) (#208336
cff64c1 
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Update message for manual rule run Modal window
(#208072)](#208072)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-27T10:22:11Z","message":"Update
message for manual rule run Modal window (#208072)\n\n##
Summary\r\n\r\n\r\nUpdate message, that currently not support only 1
action type\r\n<img width=\"670\" alt=\"Screenshot 2025-01-23 at 15 51
10\"\r\nsrc=\"https://github.com/user-attachments/assets/758a5052-303d-4155-8320-e4c3e620c496\"\r\n/>","sha":"bfddf6c1336594581b10fcf02ca20e6d4e90995e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Update
message for manual rule run Modal
window","number":208072,"url":"https://github.com/elastic/kibana/pull/208072","mergeCommit":{"message":"Update
message for manual rule run Modal window (#208072)\n\n##
Summary\r\n\r\n\r\nUpdate message, that currently not support only 1
action type\r\n<img width=\"670\" alt=\"Screenshot 2025-01-23 at 15 51
10\"\r\nsrc=\"https://github.com/user-attachments/assets/758a5052-303d-4155-8320-e4c3e620c496\"\r\n/>","sha":"bfddf6c1336594581b10fcf02ca20e6d4e90995e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208072","number":208072,"mergeCommit":{"message":"Update
message for manual rule run Modal window (#208072)\n\n##
Summary\r\n\r\n\r\nUpdate message, that currently not support only 1
action type\r\n<img width=\"670\" alt=\"Screenshot 2025-01-23 at 15 51
10\"\r\nsrc=\"https://github.com/user-attachments/assets/758a5052-303d-4155-8320-e4c3e620c496\"\r\n/>","sha":"bfddf6c1336594581b10fcf02ca20e6d4e90995e"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
@nkhristinin @JoseLuisGJ
Update message for manual rule run Modal window (elastic#208072)
cbca4a6 
## Summary


Update message, that currently not support only 1 action type
<img width="670" alt="Screenshot 2025-01-23 at 15 51 10"
src="https://github.com/user-attachments/assets/758a5052-303d-4155-8320-e4c3e620c496"
/>
@yctercero yctercero mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastasha-solomon nastasha-solomon nastasha-solomon approved these changes

@vitaliidm vitaliidm vitaliidm approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkhristinin @kibanamachine @elasticmachine @nastasha-solomon @vitaliidm