move content-management and react files left behind in the packages folder #206874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
PhilippeOberti
changed the title
…kages/shared/content-management/content_insights` and `src/platform/packages/shared/content-management/favorites`
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12813852813 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 16, 2025
…older (elastic#206874) ## Summary While looking at the `packages` folder at the root of Kibana, I noticed some files were left over in otherwise empty folders: - 2 README files were left in the `content-management` folder - 1 README file and 1 png file were left in the `react` folder The rest of the content was moved to a new location as part of the Sustainable Kibana Architecture effort (see [this PR](elastic#205593) and [that one](elastic#205924)) and I wonder if those few files were left behind by mistake. I did not making any changes to the content of the files, I just moved them to their respective new locations. Please let me know if these were left behind intentionally, or if they should be deleted instead of moved! ### Notes The `appex-sharedux` codeowner only appeared after pushing the second commit which impacts the `react` folder. I realized that the codeowners file was pointing to the folder within `src/platform/packages/shared/content-management/content_insights` and `src/platform/packages/shared/content-management/favorites` so update it to point to the parent folder, which now contains the moved README files. I hope that's ok! --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 097fb03)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 16, 2025
…ages folder (#206874) (#206986) # Backport This will backport the following commits from `main` to `8.x`: - [move content-management and react files left behind in the packages folder (#206874)](#206874) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-16T17:01:20Z","message":"move content-management and react files left behind in the packages folder (#206874)\n\n## Summary\r\n\r\nWhile looking at the `packages` folder at the root of Kibana, I noticed\r\nsome files were left over in otherwise empty folders:\r\n- 2 README files were left in the `content-management` folder\r\n- 1 README file and 1 png file were left in the `react` folder\r\n\r\nThe rest of the content was moved to a new location as part of the\r\nSustainable Kibana Architecture effort (see [this\r\nPR](#205593) and [that\r\none](#205924)) and I wonder if\r\nthose few files were left behind by mistake.\r\n\r\nI did not making any changes to the content of the files, I just moved\r\nthem to their respective new locations.\r\n\r\nPlease let me know if these were left behind intentionally, or if they\r\nshould be deleted instead of moved!\r\n\r\n### Notes\r\n\r\nThe `appex-sharedux` codeowner only appeared after pushing the second\r\ncommit which impacts the `react` folder. I realized that the codeowners\r\nfile was pointing to the folder within\r\n`src/platform/packages/shared/content-management/content_insights` and\r\n`src/platform/packages/shared/content-management/favorites` so update it\r\nto point to the parent folder, which now contains the moved README\r\nfiles. I hope that's ok!\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"097fb03bc487cb97d2b1a6871521cb90b895900b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:version","v8.18.0"],"title":"move content-management and react files left behind in the packages folder","number":206874,"url":"https://github.com/elastic/kibana/pull/206874","mergeCommit":{"message":"move content-management and react files left behind in the packages folder (#206874)\n\n## Summary\r\n\r\nWhile looking at the `packages` folder at the root of Kibana, I noticed\r\nsome files were left over in otherwise empty folders:\r\n- 2 README files were left in the `content-management` folder\r\n- 1 README file and 1 png file were left in the `react` folder\r\n\r\nThe rest of the content was moved to a new location as part of the\r\nSustainable Kibana Architecture effort (see [this\r\nPR](#205593) and [that\r\none](#205924)) and I wonder if\r\nthose few files were left behind by mistake.\r\n\r\nI did not making any changes to the content of the files, I just moved\r\nthem to their respective new locations.\r\n\r\nPlease let me know if these were left behind intentionally, or if they\r\nshould be deleted instead of moved!\r\n\r\n### Notes\r\n\r\nThe `appex-sharedux` codeowner only appeared after pushing the second\r\ncommit which impacts the `react` folder. I realized that the codeowners\r\nfile was pointing to the folder within\r\n`src/platform/packages/shared/content-management/content_insights` and\r\n`src/platform/packages/shared/content-management/favorites` so update it\r\nto point to the parent folder, which now contains the moved README\r\nfiles. I hope that's ok!\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"097fb03bc487cb97d2b1a6871521cb90b895900b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206874","number":206874,"mergeCommit":{"message":"move content-management and react files left behind in the packages folder (#206874)\n\n## Summary\r\n\r\nWhile looking at the `packages` folder at the root of Kibana, I noticed\r\nsome files were left over in otherwise empty folders:\r\n- 2 README files were left in the `content-management` folder\r\n- 1 README file and 1 png file were left in the `react` folder\r\n\r\nThe rest of the content was moved to a new location as part of the\r\nSustainable Kibana Architecture effort (see [this\r\nPR](#205593) and [that\r\none](#205924)) and I wonder if\r\nthose few files were left behind by mistake.\r\n\r\nI did not making any changes to the content of the files, I just moved\r\nthem to their respective new locations.\r\n\r\nPlease let me know if these were left behind intentionally, or if they\r\nshould be deleted instead of moved!\r\n\r\n### Notes\r\n\r\nThe `appex-sharedux` codeowner only appeared after pushing the second\r\ncommit which impacts the `react` folder. I realized that the codeowners\r\nfile was pointing to the folder within\r\n`src/platform/packages/shared/content-management/content_insights` and\r\n`src/platform/packages/shared/content-management/favorites` so update it\r\nto point to the parent folder, which now contains the moved README\r\nfiles. I hope that's ok!\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"097fb03bc487cb97d2b1a6871521cb90b895900b"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this pull request
Jan 23, 2025
…older (elastic#206874) ## Summary While looking at the `packages` folder at the root of Kibana, I noticed some files were left over in otherwise empty folders: - 2 README files were left in the `content-management` folder - 1 README file and 1 png file were left in the `react` folder The rest of the content was moved to a new location as part of the Sustainable Kibana Architecture effort (see [this PR](elastic#205593) and [that one](elastic#205924)) and I wonder if those few files were left behind by mistake. I did not making any changes to the content of the files, I just moved them to their respective new locations. Please let me know if these were left behind intentionally, or if they should be deleted instead of moved! ### Notes The `appex-sharedux` codeowner only appeared after pushing the second commit which impacts the `react` folder. I realized that the codeowners file was pointing to the folder within `src/platform/packages/shared/content-management/content_insights` and `src/platform/packages/shared/content-management/favorites` so update it to point to the parent folder, which now contains the moved README files. I hope that's ok! --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While looking at the
packagesfolder at the root of Kibana, I noticed some files were left over in otherwise empty folders:content-managementfolderreactfolderThe rest of the content was moved to a new location as part of the Sustainable Kibana Architecture effort (see this PR and that one) and I wonder if those few files were left behind by mistake.
I did not making any changes to the content of the files, I just moved them to their respective new locations.
Please let me know if these were left behind intentionally, or if they should be deleted instead of moved!
Notes
The
appex-shareduxcodeowner only appeared after pushing the second commit which impacts thereactfolder. I realized that the codeowners file was pointing to the folder withinsrc/platform/packages/shared/content-management/content_insightsandsrc/platform/packages/shared/content-management/favoritesso update it to point to the parent folder, which now contains the moved README files. I hope that's ok!