Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Apply different color tokens for themes #206254

Merged
merged 5 commits into from
Jan 10, 2025
Merged

[SecuritySolution] Apply different color tokens for themes #206254

merged 5 commits into from
Jan 10, 2025

Conversation

angorayc
Copy link
Contributor

Summary

Previous changes applied same tokens for Borealis and Amsterdam:
#204631 (comment)

PR above causes color changes to the current theme, after discussing with UX, we decide to maintain different color tokens until Borealis is launched. This PR should revert the color changed on Amsterdam by the previous PR and only apply the new color for Borealis.

Current and Amsterdam Borealis
Source: Hard coded: #d36186 Source: euiColorVis4 - #EE72A6
Dest: Hard coded: #9170b8 Dest: euiColorVis2 - #61A2FF

Host IPs:

Current and Amsterdam Borealis
host_IPs host_bor_light
host_IPs_dark host_bor_dark

Network IPs:

Current and Amsterdam Borealis
network_IPs network_bor_light
host_IPs_dark network_bor_dark

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@angorayc angorayc requested a review from a team as a code owner January 10, 2025 11:05
@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Jan 10, 2025
@angorayc angorayc mentioned this pull request Jan 10, 2025
Closed
@angorayc angorayc linked an issue Jan 10, 2025 that may be closed by this pull request
[Security Solution][Explore][EUI visual refresh] make sure color palettes are theme aware #202498
Closed
agusruidiazgd
agusruidiazgd approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@agusruidiazgd agusruidiazgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@angorayc angorayc enabled auto-merge (squash) January 10, 2025 13:51
@angorayc angorayc mentioned this pull request Jan 10, 2025
Open
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 10, 2025 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #7 / Automated Response Actions "before all" hook for "should have been called against a created host" "before all" hook for "should have been called against a created host"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #7 / Automated Response Actions "before all" hook for "should have been called against a created host" "before all" hook for "should have been called against a created host"
  • [job] [logs] Defend Workflows Cypress Tests #19 / Document signing: "before all" hook for "should fail if data tampered" "before all" hook for "should fail if data tampered"
  • [job] [logs] Defend Workflows Cypress Tests #1 / Endpoint generated alerts "before each" hook for "should create a Detection Engine alert from an endpoint alert" "before each" hook for "should create a Detection Engine alert from an endpoint alert"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #1 / Endpoint generated alerts "before each" hook for "should create a Detection Engine alert from an endpoint alert" "before each" hook for "should create a Detection Engine alert from an endpoint alert"
  • [job] [logs] Defend Workflows Cypress Tests #12 / Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #10 / Endpoints page "before all" hook for "Shows endpoint on the list" "before all" hook for "Shows endpoint on the list"
  • [job] [logs] Defend Workflows Cypress Tests #4 / Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #5 / Response console Execute operations: "before all" hook for ""execute --command" - should execute a command" "before all" hook for ""execute --command" - should execute a command"
  • [job] [logs] Defend Workflows Cypress Tests #5 / Response console File operations: "before all" hook for ""get-file --path" - should retrieve a file" "before all" hook for ""get-file --path" - should retrieve a file"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #6 / Response console File operations: "before all" hook for ""get-file --path" - should retrieve a file" "before all" hook for ""get-file --path" - should retrieve a file"
  • [job] [logs] Defend Workflows Cypress Tests #20 / Response console From endpoint list "before all" hook for "should open responder" "before all" hook for "should open responder"
  • [job] [logs] Defend Workflows Cypress Tests #6 / Response console Host Isolation: "before all" hook for "should isolate a host from response console" "before all" hook for "should isolate a host from response console"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #7 / Response console Host Isolation: "before all" hook for "should isolate a host from response console" "before all" hook for "should isolate a host from response console"
  • [job] [logs] Defend Workflows Cypress Tests #7 / Response console Host Isolation: "before all" hook for "should release an isolated host via response console" "before all" hook for "should release an isolated host via response console"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #8 / Response console Host Isolation: "before all" hook for "should release an isolated host via response console" "before all" hook for "should release an isolated host via response console"
  • [job] [logs] Defend Workflows Cypress Tests #18 / Response console: From Alerts "before all" hook for "should open responder from alert details flyout" "before all" hook for "should open responder from alert details flyout"
  • [job] [logs] Defend Workflows Cypress Tests #1 / Unenroll agent from fleet changing when agent tamper protection is enabled but then is switched to a policy with it disabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
  • [job] [logs] Defend Workflows Cypress Tests #20 / Unenroll agent from fleet when agent tamper protection is disabled but then is switched to a policy with it enabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
  • [job] [logs] Defend Workflows Cypress Tests #18 / Unenroll agent from fleet when agent tamper protection is enabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
  • [job] [logs] Defend Workflows Cypress Tests #16 / Unenroll agent from fleet with agent tamper protection is disabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
  • [job] [logs] Defend Workflows Cypress Tests #3 / Uninstall agent from host changing agent policy when agent tamper protection is disabled but then is switched to a policy with it enabled "before each" hook for "should uninstall from host without issues" "before each" hook for "should uninstall from host without issues"
  • [job] [logs] Defend Workflows Cypress Tests #5 / Uninstall agent from host changing agent policy when agent tamper protection is enabled but then is switched to a policy with it also enabled "before each" hook for "should uninstall from host without issues" "before each" hook for "should uninstall from host without issues"
  • [job] [logs] Defend Workflows Cypress Tests #4 / Uninstall agent from host changing agent policy when agent tamper protection is enabled but then is switched to a policy with it disabled "before each" hook for "should uninstall from host without issues" "before each" hook for "should uninstall from host without issues"
  • [job] [logs] Defend Workflows Cypress Tests #17 / Uninstall agent from host when agent tamper protection is disabled "before each" hook for "should uninstall from host without issues" "before each" hook for "should uninstall from host without issues"
  • [job] [logs] Defend Workflows Cypress Tests #19 / Uninstall agent from host when agent tamper protection is enabled "before each" hook for "should uninstall from host with the uninstall token" "before each" hook for "should uninstall from host with the uninstall token"

History

@angorayc angorayc merged commit 4ca5779 into elastic:main Jan 10, 2025
8 checks passed
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 13, 2025
@angorayc @delanni
[SecuritySolution] Apply different color tokens for themes (elastic#2…
810c4a6 
…06254)

## Summary

Previous changes applied same tokens for Borealis and Amsterdam:
elastic#204631 (comment)

PR above causes color changes to the current theme, after discussing
with UX, we decide to maintain different color tokens until Borealis is
launched. This PR should revert the color changed on Amsterdam by the
previous PR and only apply the new color for Borealis.

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |
|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|

### Host IPs:

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|<img width="2560" alt="host_IPs"
src="https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636"
/>|<img width="2560" alt="host_bor_light"
src="https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2"
/>|
|<img width="2558" alt="host_IPs_dark"
src="https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee"
/>|<img width="2553" alt="host_bor_dark"
src="https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8"
/>|

### Network IPs:

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|<img width="2557" alt="network_IPs"
src="https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398"
/>|<img width="2559" alt="network_bor_light"
src="https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f"
/>|
|<img width="2558" alt="host_IPs_dark"
src="https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc"
/>|<img width="2560" alt="network_bor_dark"
src="https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac"
/>|



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@angorayc @viduni94
[SecuritySolution] Apply different color tokens for themes (elastic#2…
440c4a4 
…06254)

## Summary

Previous changes applied same tokens for Borealis and Amsterdam:
elastic#204631 (comment)

PR above causes color changes to the current theme, after discussing
with UX, we decide to maintain different color tokens until Borealis is
launched. This PR should revert the color changed on Amsterdam by the
previous PR and only apply the new color for Borealis.

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|Source: Hard coded: `#d36186`|Source: `euiColorVis4` - `#EE72A6` |
|Dest: Hard coded: `#9170b8` |Dest: `euiColorVis2` - `#61A2FF`|

### Host IPs:

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|<img width="2560" alt="host_IPs"
src="https://github.com/user-attachments/assets/c0f9f317-fb02-4c96-8422-c1d2484f4636"
/>|<img width="2560" alt="host_bor_light"
src="https://github.com/user-attachments/assets/451d6604-1d7c-4a2e-82c3-74b2499852d2"
/>|
|<img width="2558" alt="host_IPs_dark"
src="https://github.com/user-attachments/assets/ac45a3ac-ecaf-46b6-91d9-68704d8639ee"
/>|<img width="2553" alt="host_bor_dark"
src="https://github.com/user-attachments/assets/e34e56fd-8202-4a3c-80c1-996718320fd8"
/>|

### Network IPs:

| Current and Amsterdam | Borealis  |
|-------------------------|----------|
|<img width="2557" alt="network_IPs"
src="https://github.com/user-attachments/assets/0e0b33d9-55b7-41a5-8910-11b80e539398"
/>|<img width="2559" alt="network_bor_light"
src="https://github.com/user-attachments/assets/f616b3ab-5032-4e69-b67e-cde39b88ea5f"
/>|
|<img width="2558" alt="host_IPs_dark"
src="https://github.com/user-attachments/assets/9613a49f-f0c6-4b63-aa56-c960fac175fc"
/>|<img width="2560" alt="network_bor_dark"
src="https://github.com/user-attachments/assets/911f0509-43ea-428a-94d6-9ce01f5425ac"
/>|



### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agusruidiazgd agusruidiazgd agusruidiazgd approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution][Explore][EUI visual refresh] make sure color palettes are theme aware
3 participants
@angorayc @elasticmachine @agusruidiazgd