Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Experiments] Flag as private #206121

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

afharo
Copy link
Member

@afharo afharo commented Jan 9, 2025

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

  • We kindly ask you to:
    • Manually fix the errors in the error section below (if there are any).
    • Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
    • Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
    • Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
    • Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
      • customised eslint rules
      • docs pointing to source code

Note

  • This PR has been auto-generated.
  • Any manual contributions will be lost if the 'relocate' script is re-run.
  • Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
  • Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

1 plugin(s) are going to be relocated:

Id Target folder
@kbn/cloud-experiments-plugin x-pack/platform/plugins/private/cloud_integrations/cloud_experiments
Updated references
./.idea/workspace.xml
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/platform/packages/private/kbn-repo-packages/package-map.json
./tsconfig.base.json
./x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/jest.config.js
./yarn.lock
.github/CODEOWNERS
Updated relative paths
x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/jest.config.js:10
x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/tsconfig.json:11
x-pack/platform/plugins/private/cloud_integrations/cloud_experiments/tsconfig.json:2

Copy link
Contributor

github-actions bot commented Jan 9, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 9, 2025
@afharo afharo marked this pull request as ready for review January 9, 2025 18:03
@afharo afharo requested a review from a team as a code owner January 9, 2025 18:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo enabled auto-merge (squash) January 9, 2025 18:03
@afharo afharo self-assigned this Jan 9, 2025
@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

cc @afharo

@afharo afharo merged commit 41a4255 into elastic:main Jan 10, 2025
9 checks passed
@afharo afharo deleted the kbn-team-1309-relocate-20250109175556 branch January 10, 2025 08:17
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12705776388

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 206121

Questions ?

Please refer to the Backport tool documentation

gsoldevila pushed a commit to gsoldevila/kibana that referenced this pull request Jan 10, 2025
(cherry picked from commit 41a4255)

# Conflicts:
#	.github/CODEOWNERS
@gsoldevila
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit that referenced this pull request Jan 10, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Experiments] Flag as private
(#206121)](#206121)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T08:17:40Z","message":"[Cloud
Experiments] Flag as private
(#206121)","sha":"41a42555f9a70bfe8f083866f2f38de24c316322","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"number":206121,"url":"https://github.com/elastic/kibana/pull/206121","mergeCommit":{"message":"[Cloud
Experiments] Flag as private
(#206121)","sha":"41a42555f9a70bfe8f083866f2f38de24c316322"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206121","number":206121,"mergeCommit":{"message":"[Cloud
Experiments] Flag as private
(#206121)","sha":"41a42555f9a70bfe8f083866f2f38de24c316322"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants