Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVC Banner] Updates the AVC Banner for 2025 #205467

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Jan 3, 2025

Summary

  • Updates the AVC banner title and blog link
  • Banner will remain visible until EOY 2025
  • Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

Screenshots

image

@parkiino parkiino requested review from a team as code owners January 3, 2025 05:50
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@parkiino parkiino added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development v8.17.0 labels Jan 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@szwarckonrad szwarckonrad requested review from szwarckonrad and removed request for tomsonpl January 3, 2025 09:35
Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving... but you should consider if tests for the changes you made should be added

@parkiino
Copy link
Contributor Author

parkiino commented Jan 7, 2025

@elasticmachine merge upstream

@parkiino parkiino enabled auto-merge (squash) January 7, 2025 15:47
@parkiino
Copy link
Contributor Author

parkiino commented Jan 7, 2025

💔 Some backports could not be created

Status Branch Result
8.x An unhandled error occurred. Please see the logs for details
8.17
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 205467

Questions ?

Please refer to the Backport tool documentation

parkiino added a commit to parkiino/kibana that referenced this pull request Jan 7, 2025
## Summary

- [x] Updates the AVC banner title and blog link
- [x] Banner will remain visible until EOY 2025
- [x] Confirm that the original AVC banner code (not the part that hides
it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

# Screenshots

![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 08535f5)

# Conflicts:
#	api_docs/kbn_avc_banner.devdocs.json
#	packages/kbn-doc-links/src/get_doc_links.ts
#	x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/overview.tsx
#	x-pack/plugins/security_solution/public/onboarding/components/onboarding_banner/onboarding_banner.tsx
@parkiino
Copy link
Contributor Author

parkiino commented Jan 7, 2025

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

parkiino added a commit to parkiino/kibana that referenced this pull request Jan 7, 2025
## Summary

- [x] Updates the AVC banner title and blog link
- [x] Banner will remain visible until EOY 2025
- [x] Confirm that the original AVC banner code (not the part that hides
it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

# Screenshots

![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 08535f5)

# Conflicts:
#	api_docs/kbn_avc_banner.devdocs.json
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
## Summary

- [x] Updates the AVC banner title and blog link
- [x] Banner will remain visible until EOY 2025 
- [x] Confirm that the original AVC banner code (not the part that hides
it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

# Screenshots

![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)

---------

Co-authored-by: Elastic Machine <[email protected]>
@nicpenning
Copy link

FYI:

As a cybersecurity practioner, this security banner is misleading due to the "with zero false positives" remark.

We see many false positives from the Elastic Defend product and I would be saddened if others get this same vibe. I recommend that Elastic drop the false positive notion or replace it with how well the product performed. Other vendors try to bring the same false claim and its not realistic. Don't get me wrong, Elastic Defend is a very effective endpoint security solution, even one of the best in the industry, but no false positives in these AVC tests is far from the real world feel of the product and how it operates. Seems like false advertising?

Anyways, just figured I would drop my input here.

Sincerely, concerned Elastic Defend user. 😀

crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
## Summary

- [x] Updates the AVC banner title and blog link
- [x] Banner will remain visible until EOY 2025 
- [x] Confirm that the original AVC banner code (not the part that hides
it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

# Screenshots

![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)

---------

Co-authored-by: Elastic Machine <[email protected]>
parkiino added a commit that referenced this pull request Jan 8, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [[AVC Banner] Updates the AVC Banner for 2025
(#205467)](#205467)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Candace
Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T18:30:27Z","message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend
Workflows","backport:prev-major","v8.17.0","v8.18.0","v8.16.3","v8.17.1"],"number":205467,"url":"https://github.com/elastic/kibana/pull/205467","mergeCommit":{"message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205467","number":205467,"mergeCommit":{"message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205816","number":205816,"state":"OPEN"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205819","number":205819,"state":"OPEN"}]}]
BACKPORT-->
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 9, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
## Summary

- [x] Updates the AVC banner title and blog link
- [x] Banner will remain visible until EOY 2025 
- [x] Confirm that the original AVC banner code (not the part that hides
it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

# Screenshots

![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)

---------

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

parkiino added a commit that referenced this pull request Jan 22, 2025
# Backport

This will backport the following commits from `main` to `8.16`:
- [[AVC Banner] Updates the AVC Banner for 2025
(#205467)](#205467)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Candace
Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T18:30:27Z","message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend
Workflows","backport:prev-major","v8.17.0","v8.18.0","v8.16.3","v8.17.1"],"number":205467,"url":"https://github.com/elastic/kibana/pull/205467","mergeCommit":{"message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205467","number":205467,"mergeCommit":{"message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Elastic Machine <[email protected]>
parkiino added a commit that referenced this pull request Jan 22, 2025
# Backport

This will backport the following commits from `main` to `8.17`:
- [[AVC Banner] Updates the AVC Banner for 2025
(#205467)](#205467)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Candace
Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T18:30:27Z","message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend
Workflows","backport:prev-major","v8.17.0","v8.18.0","v8.16.3","v8.17.1"],"number":205467,"url":"https://github.com/elastic/kibana/pull/205467","mergeCommit":{"message":"[AVC
Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n-
[x] Updates the AVC banner title and blog link\r\n- [x] Banner will
remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC
banner code (not the part that hides\r\nit EOY of 2024) is present in
8.16, 8.17 and 8.x branches\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine


---------

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 22, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
## Summary

- [x] Updates the AVC banner title and blog link
- [x] Banner will remain visible until EOY 2025 
- [x] Confirm that the original AVC banner code (not the part that hides
it EOY of 2024) is present in 8.16, 8.17 and 8.x branches

# Screenshots

![image](https://github.com/user-attachments/assets/c2ec37fc-4d42-45f9-aaa1-47b5a6cc715a)

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team v8.16.4 v8.17.0 v8.17.2 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants