-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AVC Banner] Updates the AVC Banner for 2025 #205467
Conversation
Pinging @elastic/fleet (Team:Fleet) |
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving... but you should consider if tests for the changes you made should be added
@elasticmachine merge upstream |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
## Summary - [x] Updates the AVC banner title and blog link - [x] Banner will remain visible until EOY 2025 - [x] Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches # Screenshots  --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 08535f5) # Conflicts: # api_docs/kbn_avc_banner.devdocs.json # packages/kbn-doc-links/src/get_doc_links.ts # x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/overview.tsx # x-pack/plugins/security_solution/public/onboarding/components/onboarding_banner/onboarding_banner.tsx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary - [x] Updates the AVC banner title and blog link - [x] Banner will remain visible until EOY 2025 - [x] Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches # Screenshots  --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 08535f5) # Conflicts: # api_docs/kbn_avc_banner.devdocs.json
## Summary - [x] Updates the AVC banner title and blog link - [x] Banner will remain visible until EOY 2025 - [x] Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches # Screenshots  --------- Co-authored-by: Elastic Machine <[email protected]>
FYI: As a cybersecurity practioner, this security banner is misleading due to the "with zero false positives" remark. We see many false positives from the Elastic Defend product and I would be saddened if others get this same vibe. I recommend that Elastic drop the false positive notion or replace it with how well the product performed. Other vendors try to bring the same false claim and its not realistic. Don't get me wrong, Elastic Defend is a very effective endpoint security solution, even one of the best in the industry, but no false positives in these AVC tests is far from the real world feel of the product and how it operates. Seems like false advertising? Anyways, just figured I would drop my input here. Sincerely, concerned Elastic Defend user. 😀 |
## Summary - [x] Updates the AVC banner title and blog link - [x] Banner will remain visible until EOY 2025 - [x] Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches # Screenshots  --------- Co-authored-by: Elastic Machine <[email protected]>
# Backport This will backport the following commits from `main` to `8.x`: - [[AVC Banner] Updates the AVC Banner for 2025 (#205467)](#205467) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T18:30:27Z","message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend Workflows","backport:prev-major","v8.17.0","v8.18.0","v8.16.3","v8.17.1"],"number":205467,"url":"https://github.com/elastic/kibana/pull/205467","mergeCommit":{"message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205467","number":205467,"mergeCommit":{"message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205816","number":205816,"state":"OPEN"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205819","number":205819,"state":"OPEN"}]}] BACKPORT-->
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
## Summary - [x] Updates the AVC banner title and blog link - [x] Banner will remain visible until EOY 2025 - [x] Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches # Screenshots  --------- Co-authored-by: Elastic Machine <[email protected]>
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
3 similar comments
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
# Backport This will backport the following commits from `main` to `8.16`: - [[AVC Banner] Updates the AVC Banner for 2025 (#205467)](#205467) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T18:30:27Z","message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend Workflows","backport:prev-major","v8.17.0","v8.18.0","v8.16.3","v8.17.1"],"number":205467,"url":"https://github.com/elastic/kibana/pull/205467","mergeCommit":{"message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205467","number":205467,"mergeCommit":{"message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]>
# Backport This will backport the following commits from `main` to `8.17`: - [[AVC Banner] Updates the AVC Banner for 2025 (#205467)](#205467) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T18:30:27Z","message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"08535f54a0d9b172f8cd695a5330bcd87f896d7c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend Workflows","backport:prev-major","v8.17.0","v8.18.0","v8.16.3","v8.17.1"],"number":205467,"url":"https://github.com/elastic/kibana/pull/205467","mergeCommit":{"message":"[AVC Banner] Updates the AVC Banner for 2025 (#205467)\n\n## Summary\r\n\r\n- [x] Updates the AVC banner title and blog link\r\n- [x] Banner will remain visible until EOY 2025 \r\n- [x] Confirm that the original AVC banner code (not the part that hides\r\nit EOY of 2024) is present in 8.16, 8.17 and 8.x branches\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine --------- Co-authored-by: Elastic Machine <[email protected]>
## Summary - [x] Updates the AVC banner title and blog link - [x] Banner will remain visible until EOY 2025 - [x] Confirm that the original AVC banner code (not the part that hides it EOY of 2024) is present in 8.16, 8.17 and 8.x branches # Screenshots  --------- Co-authored-by: Elastic Machine <[email protected]>
Summary
Screenshots