Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Attack discovery] Update Attack Discovery evaluation prompts #205002

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

susan-shu-c
Copy link
Member

@susan-shu-c susan-shu-c commented Dec 19, 2024

[Security Solution] [Attack discovery] Update Attack Discovery evaluation prompts

This PR updates prompts used to evaluate the initial outputs of Attack Discovery.
Only text was changed.

@susan-shu-c susan-shu-c requested a review from a team as a code owner December 19, 2024 19:47
@susan-shu-c susan-shu-c added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI labels Dec 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@susan-shu-c susan-shu-c added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.18.0 labels Dec 19, 2024
Copy link
Contributor

@andrew-goldstein andrew-goldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @susan-shu-c for these improvements to the evaluation prompts! 🙏
✅ Desk tested locally
LGTM 🚀

@susan-shu-c
Copy link
Member Author

Adding evaluation results:

Screenshot 2024-12-23 at 1 27 36 PM

Copy link
Contributor

@peluja1012 peluja1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @susan-shu-c!

@susan-shu-c susan-shu-c enabled auto-merge (squash) January 6, 2025 19:28
@susan-shu-c susan-shu-c added the backport:version Backport to applied version labels label Jan 6, 2025
@susan-shu-c susan-shu-c merged commit c8cd319 into elastic:main Jan 8, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12674739788

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 8, 2025
…tion prompts (elastic#205002)

[Security Solution] [Attack discovery] Update Attack Discovery
evaluation prompts

This PR updates prompts used to evaluate the initial outputs of Attack
Discovery.
Only text was changed.

(cherry picked from commit c8cd319)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 10, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…tion prompts (elastic#205002)

[Security Solution] [Attack discovery] Update Attack Discovery
evaluation prompts

This PR updates prompts used to evaluate the initial outputs of Attack
Discovery.
Only text was changed.
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kibanamachine added a commit that referenced this pull request Jan 13, 2025
…evaluation prompts (#205002) (#205931)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] [Attack discovery] Update Attack Discovery
evaluation prompts
(#205002)](#205002)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Susan","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:23:58Z","message":"[Security
Solution] [Attack discovery] Update Attack Discovery evaluation prompts
(#205002)\n\n[Security Solution] [Attack discovery] Update Attack
Discovery\r\nevaluation prompts\r\n\r\nThis PR updates prompts used to
evaluate the initial outputs of Attack\r\nDiscovery.\r\nOnly text was
changed.","sha":"c8cd3191da3b87f8efb10dc1f733c84db776fa32","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","backport:version","v8.18.0"],"title":"[Security Solution] [Attack
discovery] Update Attack Discovery evaluation
prompts","number":205002,"url":"https://github.com/elastic/kibana/pull/205002","mergeCommit":{"message":"[Security
Solution] [Attack discovery] Update Attack Discovery evaluation prompts
(#205002)\n\n[Security Solution] [Attack discovery] Update Attack
Discovery\r\nevaluation prompts\r\n\r\nThis PR updates prompts used to
evaluate the initial outputs of Attack\r\nDiscovery.\r\nOnly text was
changed.","sha":"c8cd3191da3b87f8efb10dc1f733c84db776fa32"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205002","number":205002,"mergeCommit":{"message":"[Security
Solution] [Attack discovery] Update Attack Discovery evaluation prompts
(#205002)\n\n[Security Solution] [Attack discovery] Update Attack
Discovery\r\nevaluation prompts\r\n\r\nThis PR updates prompts used to
evaluate the initial outputs of Attack\r\nDiscovery.\r\nOnly text was
changed.","sha":"c8cd3191da3b87f8efb10dc1f733c84db776fa32"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Susan <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 13, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…tion prompts (elastic#205002)

[Security Solution] [Attack discovery] Update Attack Discovery
evaluation prompts

This PR updates prompts used to evaluate the initial outputs of Attack
Discovery.
Only text was changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants