-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply "[Response Ops][Alerting] Backfill actions schema changes for intermediate release #204657
Reapply "[Response Ops][Alerting] Backfill actions schema changes for intermediate release #204657
Conversation
… intermediate release (elastic#203184)" (elastic#204218) This reverts commit 42693ca.
…s-schema-updates-again
…s-schema-updates-again
…s-schema-updates-again
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Test instructions in the PR got a little more involved :-), worked as described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mappings changes LGTM, did not test locally!
@elasticmachine merge upstream |
In addition to the verification instructions, I did the following locally. Running serverless locally with .kibana_alerting_cases/_mappings
.kibana_task_manager/_mappings
I did the following:
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @ymao1 |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12659747737 |
… intermediate release (elastic#204657) ## Summary Redoing [this PR](elastic#203184) which had to be [reverted](elastic#204218). This should not be merged until [this update to the task manager v1 schema](elastic#204413) is released. ## To verify 1. Set `xpack.task_manager.unsafe.exclude_task_types: ['ad_hoc_run-backfill', 'actions:*']` in your Kibana config. 2. Run Kibana on main and create some detection rules that run frequently, with actions. 3. Schedule a manual run for your detection rules. - Because of the config, the `action_task_params` SO and the `ad_hoc_run_task_params` SO will get written but not read yet. 4. Remove the `exclude_task_types` config and "upgrade" to this PR branch and verify that rules continue to run and that the actions are triggered and the manual rule runs go through 5. Re-add the `exclude_task_types` config and let the rule run again to schedule action. Schedule another manual rule run. 6. Remove the `exclude_task_types` config and "downgrade" back to main and verify that rules continue to run, the action gets triggered and manual rule runs go through. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 11e3a0b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… intermediate release (elastic#204657) ## Summary Redoing [this PR](elastic#203184) which had to be [reverted](elastic#204218). This should not be merged until [this update to the task manager v1 schema](elastic#204413) is released. ## To verify 1. Set `xpack.task_manager.unsafe.exclude_task_types: ['ad_hoc_run-backfill', 'actions:*']` in your Kibana config. 2. Run Kibana on main and create some detection rules that run frequently, with actions. 3. Schedule a manual run for your detection rules. - Because of the config, the `action_task_params` SO and the `ad_hoc_run_task_params` SO will get written but not read yet. 4. Remove the `exclude_task_types` config and "upgrade" to this PR branch and verify that rules continue to run and that the actions are triggered and the manual rule runs go through 5. Re-add the `exclude_task_types` config and let the rule run again to schedule action. Schedule another manual rule run. 6. Remove the `exclude_task_types` config and "downgrade" back to main and verify that rules continue to run, the action gets triggered and manual rule runs go through. Co-authored-by: Elastic Machine <[email protected]>
…changes for intermediate release (#204657) (#205821) # Backport This will backport the following commits from `main` to `8.x`: - [Reapply "[Response Ops][Alerting] Backfill actions schema changes for intermediate release (#204657)](#204657) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T21:37:01Z","message":"Reapply \"[Response Ops][Alerting] Backfill actions schema changes for intermediate release (#204657)\n\n## Summary\r\n\r\nRedoing [this PR](#203184) which\r\nhad to be [reverted](https://github.com/elastic/kibana/pull/204218).\r\nThis should not be merged until [this update to the task manager v1\r\nschema](#204413) is released.\r\n\r\n## To verify\r\n1. Set `xpack.task_manager.unsafe.exclude_task_types:\r\n['ad_hoc_run-backfill', 'actions:*']` in your Kibana config.\r\n2. Run Kibana on main and create some detection rules that run\r\nfrequently, with actions.\r\n3. Schedule a manual run for your detection rules.\r\n- Because of the config, the `action_task_params` SO and the\r\n`ad_hoc_run_task_params` SO will get written but not read yet.\r\n4. Remove the `exclude_task_types` config and \"upgrade\" to this PR\r\nbranch and verify that rules continue to run and that the actions are\r\ntriggered and the manual rule runs go through\r\n5. Re-add the `exclude_task_types` config and let the rule run again to\r\nschedule action. Schedule another manual rule run.\r\n6. Remove the `exclude_task_types` config and \"downgrade\" back to main\r\nand verify that rules continue to run, the action gets triggered and\r\nmanual rule runs go through.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"11e3a0b77ef2e15bcd0eacf0572f27eeed60ea69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.18.0"],"title":"Reapply \"[Response Ops][Alerting] Backfill actions schema changes for intermediate release","number":204657,"url":"https://github.com/elastic/kibana/pull/204657","mergeCommit":{"message":"Reapply \"[Response Ops][Alerting] Backfill actions schema changes for intermediate release (#204657)\n\n## Summary\r\n\r\nRedoing [this PR](#203184) which\r\nhad to be [reverted](https://github.com/elastic/kibana/pull/204218).\r\nThis should not be merged until [this update to the task manager v1\r\nschema](#204413) is released.\r\n\r\n## To verify\r\n1. Set `xpack.task_manager.unsafe.exclude_task_types:\r\n['ad_hoc_run-backfill', 'actions:*']` in your Kibana config.\r\n2. Run Kibana on main and create some detection rules that run\r\nfrequently, with actions.\r\n3. Schedule a manual run for your detection rules.\r\n- Because of the config, the `action_task_params` SO and the\r\n`ad_hoc_run_task_params` SO will get written but not read yet.\r\n4. Remove the `exclude_task_types` config and \"upgrade\" to this PR\r\nbranch and verify that rules continue to run and that the actions are\r\ntriggered and the manual rule runs go through\r\n5. Re-add the `exclude_task_types` config and let the rule run again to\r\nschedule action. Schedule another manual rule run.\r\n6. Remove the `exclude_task_types` config and \"downgrade\" back to main\r\nand verify that rules continue to run, the action gets triggered and\r\nmanual rule runs go through.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"11e3a0b77ef2e15bcd0eacf0572f27eeed60ea69"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204657","number":204657,"mergeCommit":{"message":"Reapply \"[Response Ops][Alerting] Backfill actions schema changes for intermediate release (#204657)\n\n## Summary\r\n\r\nRedoing [this PR](#203184) which\r\nhad to be [reverted](https://github.com/elastic/kibana/pull/204218).\r\nThis should not be merged until [this update to the task manager v1\r\nschema](#204413) is released.\r\n\r\n## To verify\r\n1. Set `xpack.task_manager.unsafe.exclude_task_types:\r\n['ad_hoc_run-backfill', 'actions:*']` in your Kibana config.\r\n2. Run Kibana on main and create some detection rules that run\r\nfrequently, with actions.\r\n3. Schedule a manual run for your detection rules.\r\n- Because of the config, the `action_task_params` SO and the\r\n`ad_hoc_run_task_params` SO will get written but not read yet.\r\n4. Remove the `exclude_task_types` config and \"upgrade\" to this PR\r\nbranch and verify that rules continue to run and that the actions are\r\ntriggered and the manual rule runs go through\r\n5. Re-add the `exclude_task_types` config and let the rule run again to\r\nschedule action. Schedule another manual rule run.\r\n6. Remove the `exclude_task_types` config and \"downgrade\" back to main\r\nand verify that rules continue to run, the action gets triggered and\r\nmanual rule runs go through.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"11e3a0b77ef2e15bcd0eacf0572f27eeed60ea69"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <[email protected]>
… intermediate release (elastic#204657) ## Summary Redoing [this PR](elastic#203184) which had to be [reverted](elastic#204218). This should not be merged until [this update to the task manager v1 schema](elastic#204413) is released. ## To verify 1. Set `xpack.task_manager.unsafe.exclude_task_types: ['ad_hoc_run-backfill', 'actions:*']` in your Kibana config. 2. Run Kibana on main and create some detection rules that run frequently, with actions. 3. Schedule a manual run for your detection rules. - Because of the config, the `action_task_params` SO and the `ad_hoc_run_task_params` SO will get written but not read yet. 4. Remove the `exclude_task_types` config and "upgrade" to this PR branch and verify that rules continue to run and that the actions are triggered and the manual rule runs go through 5. Re-add the `exclude_task_types` config and let the rule run again to schedule action. Schedule another manual rule run. 6. Remove the `exclude_task_types` config and "downgrade" back to main and verify that rules continue to run, the action gets triggered and manual rule runs go through. Co-authored-by: Elastic Machine <[email protected]>
… intermediate release (elastic#204657) ## Summary Redoing [this PR](elastic#203184) which had to be [reverted](elastic#204218). This should not be merged until [this update to the task manager v1 schema](elastic#204413) is released. ## To verify 1. Set `xpack.task_manager.unsafe.exclude_task_types: ['ad_hoc_run-backfill', 'actions:*']` in your Kibana config. 2. Run Kibana on main and create some detection rules that run frequently, with actions. 3. Schedule a manual run for your detection rules. - Because of the config, the `action_task_params` SO and the `ad_hoc_run_task_params` SO will get written but not read yet. 4. Remove the `exclude_task_types` config and "upgrade" to this PR branch and verify that rules continue to run and that the actions are triggered and the manual rule runs go through 5. Re-add the `exclude_task_types` config and let the rule run again to schedule action. Schedule another manual rule run. 6. Remove the `exclude_task_types` config and "downgrade" back to main and verify that rules continue to run, the action gets triggered and manual rule runs go through. Co-authored-by: Elastic Machine <[email protected]>
… intermediate release (elastic#204657) ## Summary Redoing [this PR](elastic#203184) which had to be [reverted](elastic#204218). This should not be merged until [this update to the task manager v1 schema](elastic#204413) is released. ## To verify 1. Set `xpack.task_manager.unsafe.exclude_task_types: ['ad_hoc_run-backfill', 'actions:*']` in your Kibana config. 2. Run Kibana on main and create some detection rules that run frequently, with actions. 3. Schedule a manual run for your detection rules. - Because of the config, the `action_task_params` SO and the `ad_hoc_run_task_params` SO will get written but not read yet. 4. Remove the `exclude_task_types` config and "upgrade" to this PR branch and verify that rules continue to run and that the actions are triggered and the manual rule runs go through 5. Re-add the `exclude_task_types` config and let the rule run again to schedule action. Schedule another manual rule run. 6. Remove the `exclude_task_types` config and "downgrade" back to main and verify that rules continue to run, the action gets triggered and manual rule runs go through. Co-authored-by: Elastic Machine <[email protected]>
Summary
Redoing this PR which had to be reverted. This should not be merged until this update to the task manager v1 schema is released.
To verify
xpack.task_manager.unsafe.exclude_task_types: ['ad_hoc_run-backfill', 'actions:*']
in your Kibana config.action_task_params
SO and thead_hoc_run_task_params
SO will get written but not read yet.exclude_task_types
config and "upgrade" to this PR branch and verify that rules continue to run and that the actions are triggered and the manual rule runs go throughexclude_task_types
config and let the rule run again to schedule action. Schedule another manual rule run.exclude_task_types
config and "downgrade" back to main and verify that rules continue to run, the action gets triggered and manual rule runs go through.