Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] replace embeddable.ViewMode with presentation-publishing.ViewMode #204464

Merged
merged 8 commits into from
Dec 18, 2024
Merged

[dashboard] replace embeddable.ViewMode with presentation-publishing.ViewMode #204464

merged 8 commits into from
Dec 18, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 16, 2024 •
edited by kibanamachine
Loading

null

@nreese
Copy link
Contributor Author

nreese commented Dec 16, 2024

/ci

@nreese nreese marked this pull request as ready for review December 17, 2024 19:44
@nreese nreese requested a review from a team as a code owner December 17, 2024 19:44
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Dec 17, 2024
@nreese
Copy link
Contributor Author

nreese commented Dec 17, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 17, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / useOnSubmit default API response should set index 1 name to package policy on init if no package policies exist for this package

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 668.0KB 667.7KB -291.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 52.5KB 52.4KB -157.0B

History

ThomThomson
ThomThomson approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Are you planning on removing usages of the legacy viewMode from other plugins before deleting its definition?

src/plugins/dashboard/public/dashboard_app/dashboard_app.tsx
@@ -154,7 +154,7 @@ export function DashboardApp({
// if print mode is active, force viewMode.PRINT
...(screenshotModeService.isScreenshotMode() &&
screenshotModeService.getScreenshotContext('layout') === 'print'
? { viewMode: ViewMode.PRINT }
? { viewMode: 'print' as ViewMode }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the cast here needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because its a new object so viewMode is untyped

@nreese
Copy link
Contributor Author

nreese commented Dec 18, 2024

Are you planning on removing usages of the legacy viewMode from other plugins before deleting its definition?

Yes

@nreese nreese merged commit 9f0c5fb into elastic:main Dec 18, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12398336219

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
@nreese
[dashboard] replace embeddable.ViewMode with presentation-publishing.…
fcc48ea 
…ViewMode (elastic#204464)

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 9f0c5fb)
@kibanamachine kibanamachine mentioned this pull request Dec 18, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @nreese
[8.x] [dashboard] replace embeddable.ViewMode with presentation-publi…
0f950a5 
…shing.ViewMode (#204464) (#204813)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[dashboard] replace embeddable.ViewMode with
presentation-publishing.ViewMode
(#204464)](#204464)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T17:38:15Z","message":"[dashboard]
replace embeddable.ViewMode with presentation-publishing.ViewMode
(#204464)\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"9f0c5fbe21016cebec49bcba134ba613ef856098","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"[dashboard]
replace embeddable.ViewMode with
presentation-publishing.ViewMode","number":204464,"url":"https://github.com/elastic/kibana/pull/204464","mergeCommit":{"message":"[dashboard]
replace embeddable.ViewMode with presentation-publishing.ViewMode
(#204464)\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"9f0c5fbe21016cebec49bcba134ba613ef856098"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204464","number":204464,"mergeCommit":{"message":"[dashboard]
replace embeddable.ViewMode with presentation-publishing.ViewMode
(#204464)\n\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"9f0c5fbe21016cebec49bcba134ba613ef856098"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@nreese @elasticmachine @JoseLuisGJ
[dashboard] replace embeddable.ViewMode with presentation-publishing.…
0ab92c8 
…ViewMode (elastic#204464)

Co-authored-by: Elastic Machine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@nreese @elasticmachine @benakansara
[dashboard] replace embeddable.ViewMode with presentation-publishing.…
7041ece 
…ViewMode (elastic#204464)

Co-authored-by: Elastic Machine <[email protected]>
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@nreese @elasticmachine @viduni94
[dashboard] replace embeddable.ViewMode with presentation-publishing.…
870bce7 
…ViewMode (elastic#204464)

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @ThomThomson