Upgrade to EUI 1.1.0 #20411
Upgrade to EUI 1.1.0 #20411
Conversation
|
blocked by elastic/eui#965 EuiPopover does not get displayed in an EuiFlyout. This occurs with the inspector |
💔 Build Failed |
|
elastic/eui#965 has been resolved in EUI 1.1.0 and now the inspector popover is visible. |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
|
||
| test('add control btn', () => { |
There was a problem hiding this comment.
Nitpick: can we rename btn to button while we're here?
| @@ -364,7 +364,10 @@ export function VisualizePageProvider({ getService, getPageObjects }) { | |||
| async setInspectorTablePageSize(size) { | |||
| const panel = await testSubjects.find('inspectorPanel'); | |||
| await find.clickByButtonText('Rows per page: 20', panel); | |||
| await find.clickByButtonText(`${size} rows`, panel); | |||
| // Table size buttons are in popover element that is not under the inspectorPanel | |||
| // but are in an it's own portal attached directly to the body | |||
There was a problem hiding this comment.
Can we rephrase this? I didn't know what "Table size buttons" meant until I figured out the context -- at first I thought it was a reference to buttons that are table-sized.
// The buttons for setting table page size are in a popover element. This popover
// element appears as if it's part of the inspectorPanel but it's really attached
// to the body element by a portal.| await find.clickByButtonText(`${size} rows`, panel); | ||
| // Table size buttons are in popover element that is not under the inspectorPanel | ||
| // but are in an it's own portal attached directly to the body | ||
| const tableSizesPopover = await find.byCssSelector('.euiPanel'); |
There was a problem hiding this comment.
Any chance we can use a data-test-subj selector here?
There was a problem hiding this comment.
The buttons are created with EuiBasicTable and I do not think there is any way to attach data-test-subjs to the buttons
💚 Build Succeeded |
* Upgrade to EUI 1.0.1 * upgraded to eui 1.1.0 * fix setInspectorTablePageSize function in functional tests * better comment about basic table pagination buttons
No description provided.